Re: [PATCH BlueZ v3 1/5] build-sys: Don't build gdbus several times

[Lucas De Marchi <lucas.demarchi@profusion.mobi>]

On Fri, Jun 21, 2013 at 7:47 PM, Marcel Holtmann <marcel@holtmann.org> wrot=
e:
> Hi Lucas,
>
>>>> We are currently compiling gdbus 3 times: one for tests, one for
>>>> bluetoothd and another for obexd.
>>>
>>> we recompile because of the different CFLAGS for these binaries.
>>
>> But they shouldn=B4t be affecting gdbus.
>>
>>>
>>>> $ ls gdbus/*watch.o
>>>> gdbus/bluetoothd-watch.o  gdbus/obexd-watch.o  gdbus/watch.o
>>>>
>>>> Instead of prepending $(gdbus_sources) to several _SOURCES variable, u=
se
>>>> a convenience library.
>>>
>>> When we switched to non-recursive build, we stopped building interim li=
braries. What is the benefit of going back to building them. I am personall=
y fine with building gdbus several times.
>>
>> It=B4s more that there=B4s no advantage doing otherwise. The small benef=
it
>> is building less files and letting it simpler.
>
> then at least get into a bit of a standard habit. We are building libblue=
tooth into a public and private version.
>
> Currently we name it libbluetooth-private, but maybe following the system=
d "standard", we should start calling that libbluetooth-internal. And then =
libgdbus-internal.

ok

>
> You also do realize that I will make you do this for all other projects u=
sing gdbus.

hahaha... ok

Lucas De Marchi