From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: Michal Labedzki <michal.labedzki@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com,
vani.patel@stericsson.com, joohi.rastogi@stericsson.com
Subject: Re: [PATCH 1/3] avrcp: Fix response ctype of AbortContinuingResponse
Date: Fri, 2 Mar 2012 14:16:27 -0300 [thread overview]
Message-ID: <CAMOw1v6vqzPSz0awNy1XNHFAjfoRqf76e1ERAbQ-fmEipMGH-A@mail.gmail.com> (raw)
In-Reply-To: <1330613135-16552-1-git-send-email-michal.labedzki@tieto.com>
On Thu, Mar 1, 2012 at 11:45 AM, Michal Labedzki
<michal.labedzki@tieto.com> wrote:
> Request ctype of "AbortContinuingResponse" is CONTROL, so response should be
> ACCEPTED instead of STABLE. This affect PTS Test Case for TP/RCR/BV-04-C.
> ---
> audio/avrcp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avrcp.c b/audio/avrcp.c
> index c9ec314..4573133 100644
> --- a/audio/avrcp.c
> +++ b/audio/avrcp.c
> @@ -986,7 +986,7 @@ static uint8_t avrcp_handle_abort_continuing(struct avrcp_player *player,
> player_abort_pending_pdu(player);
> pdu->params_len = 0;
>
> - return AVC_CTYPE_STABLE;
> + return AVC_CTYPE_ACCEPTED;
What version of PTS you are running? It seems like PTS was accepting
it before. Last time I checked it was passing exactly this test, but
searching PTS bugs I found this:
https://www.bluetooth.org/pts/issues/view_issue.cfm?id=8043 (Created:
10-Jun-11 by: Bradford Ayres ID: 38385)
So you have my ACK here.
Lucas De Marchi
prev parent reply other threads:[~2012-03-02 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 14:45 [PATCH 1/3] avrcp: Fix response ctype of AbortContinuingResponse Michal Labedzki
2012-03-01 14:45 ` [PATCH 2/3] avrcp: Add error code for rejected vendor command Michal Labedzki
2012-03-01 15:34 ` Luiz Augusto von Dentz
2012-03-02 9:39 ` Michal Labedzki
2012-03-02 16:59 ` Lucas De Marchi
2012-03-07 16:23 ` [PATCH v3] " Michal Labedzki
2012-03-13 11:51 ` Johan Hedberg
2012-03-01 14:45 ` [PATCH 3/3] avrcp: Treat position as unknown when duration is unavailable Michal Labedzki
2012-03-01 15:43 ` Luiz Augusto von Dentz
2012-03-02 21:31 ` Lucas De Marchi
2012-03-07 16:35 ` Michal Labedzki
2012-03-01 15:50 ` [PATCH 1/3] avrcp: Fix response ctype of AbortContinuingResponse Luiz Augusto von Dentz
2012-03-02 17:16 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMOw1v6vqzPSz0awNy1XNHFAjfoRqf76e1ERAbQ-fmEipMGH-A@mail.gmail.com \
--to=lucas.demarchi@profusion.mobi \
--cc=joohi.rastogi@stericsson.com \
--cc=kanak.gupta@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.labedzki@tieto.com \
--cc=vani.patel@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).