From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: David Miller <davem@davemloft.net>
Cc: dh.herrmann@googlemail.com, gustavo@padovan.org,
linville@tuxdriver.com, linux-bluetooth@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix coding style
Date: Mon, 7 May 2012 16:40:01 -0300 [thread overview]
Message-ID: <CAMOw1v7LGZ9jN3BdRSuw5iBNWUNOff+aaUCcXaz+YShpxjLLHA@mail.gmail.com> (raw)
In-Reply-To: <20120506.145304.1998242927519675381.davem@davemloft.net>
On Sun, May 6, 2012 at 3:53 PM, David Miller <davem@davemloft.net> wrote:
> From: David Herrmann <dh.herrmann@googlemail.com>
> Date: Sun, 6 May 2012 19:46:46 +0200
>
>> Whose rules are they?
>
> Find me an example in another major core subsystem, let's use
The ones he pointed out, coming from Linus aren't enough?
> mm/memory.c as an example as that file gets hit by a lot of people,
> that uses the multi-line conditional TAB-only crap you guys seem to
> keep using.
Look again at this file and you'll see there is mixed style.
>
> They don't. All the examples you'll find are of the form:
>
> if (a &&
> b)
>
> not:
>
> if (a &&
> b)
>
> like I see happening in bluetooth all the time.
>
> How did you think they figured that out? Did they read someone's
> mind?
No, they used the default in emacs or another editor that has this as
default, i.e. mix tabs and spaces
Regards,
Lucas De Marchi
next prev parent reply other threads:[~2012-05-07 19:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:59 [PATCH] Bluetooth: Fix coding style Gustavo Padovan
2012-05-06 16:02 ` Marcel Holtmann
2012-05-06 16:36 ` David Miller
2012-05-06 17:46 ` David Herrmann
2012-05-06 18:53 ` David Miller
2012-05-07 8:14 ` Andrei Emeltchenko
2012-05-07 8:21 ` Arend van Spriel
2012-05-07 8:29 ` Andrei Emeltchenko
2012-05-07 10:06 ` Arend van Spriel
2012-05-07 15:52 ` David Miller
2012-05-07 19:49 ` Lucas De Marchi
2012-05-07 20:06 ` David Miller
2012-05-07 20:14 ` Arend van Spriel
2012-05-07 21:33 ` Marcel Holtmann
2012-05-07 21:41 ` David Miller
2012-05-07 17:06 ` Marcel Holtmann
2012-05-07 17:55 ` David Miller
2012-05-07 21:22 ` Marcel Holtmann
2012-05-07 23:24 ` Joe Perches
2012-05-07 19:40 ` Lucas De Marchi [this message]
2012-05-07 15:24 ` Gustavo Padovan
2012-05-07 15:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMOw1v7LGZ9jN3BdRSuw5iBNWUNOff+aaUCcXaz+YShpxjLLHA@mail.gmail.com \
--to=lucas.demarchi@profusion.mobi \
--cc=davem@davemloft.net \
--cc=dh.herrmann@googlemail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).