From: Loic Poulain <loic.poulain@linaro.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, kkapra@codeaurora.org
Subject: Re: [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function
Date: Wed, 25 Apr 2018 12:00:36 +0200 [thread overview]
Message-ID: <CAMZdPi90M71dXo+mHf=9X0AyZkBm_zNk0qQ+O-bRqcuQSabP0w@mail.gmail.com> (raw)
In-Reply-To: <21D02E4F-2AFB-4B2F-9696-969E1632D70D@holtmann.org>
Hi Marcel,
>
> so this is not a _sync command. You are not waiting for the completion. So this is more like __hci_cmd_send or __hci_cmd_submit. I am also debating if this should be limited to vendor OGF only, meaning it should throw an error for all others.
This makes sense, I agree we should not allow standard HCI command to
be unresponded and strictly follow the specification.
I think __hci_cmd_send/submit is a bit too generic and we already have
a hci_send_cmd which has a different behavior, don't want to cause
confusion. So what about __hci_cmd_noresp or __hci_cmd_vendor...?
Regards,
Loic
next prev parent reply other threads:[~2018-04-25 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 17:59 [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function Loic Poulain
2018-04-23 17:59 ` [PATCH 2/2] Bluetooth: btqca: Add AR3002 rampatch support Loic Poulain
2018-04-24 15:13 ` Marcel Holtmann
2018-04-25 7:58 ` Loic Poulain
2018-04-25 12:16 ` bgodavar
2018-04-25 13:37 ` Loic Poulain
2018-04-25 15:19 ` bgodavar
2018-04-26 6:52 ` Loic Poulain
2018-04-24 15:10 ` [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function Marcel Holtmann
2018-04-25 10:00 ` Loic Poulain [this message]
2018-04-25 12:10 ` Marcel Holtmann
2018-04-25 13:34 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZdPi90M71dXo+mHf=9X0AyZkBm_zNk0qQ+O-bRqcuQSabP0w@mail.gmail.com' \
--to=loic.poulain@linaro.org \
--cc=kkapra@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).