From: Loic Poulain <loic.poulain@linaro.org>
To: bgodavar@codeaurora.org
Cc: Marcel Holtmann <marcel@holtmann.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, kkapra@codeaurora.org
Subject: Re: [PATCH 2/2] Bluetooth: btqca: Add AR3002 rampatch support
Date: Thu, 26 Apr 2018 08:52:54 +0200 [thread overview]
Message-ID: <CAMZdPi9=VsrfomPCZURuGApEzakjKjD_8YjHfnO+i4e-1EgMLA@mail.gmail.com> (raw)
In-Reply-To: <eec3a56977ca821c1e13537ab35b0c97@codeaurora.org>
Hi Balakrishna,
> A small suggestion from my side, suppose in near future ROME <v3.2 wanted to
> go with new format i.e. acknowledging for last segment of RAM patch.
> then checking rom_build field may not work.
> i.e.
> if (le16_to_cpu(tlv_patch->rom_build) >= 0x0302)
> config->dnld_mode = tlv_patch->download_mode;
>
> i suggest you to check the byte download_mode directly and decide to wait
> for ACK from SoC, for every RAM patch segment sent.
> i think byte download_mode is explicitly for mode of downloading the patch
> i.e. with ACK or NACK. (pls double confirm about this byte).
Yes AFAIK, this byte is for download mode or reserved (0). So yes we
can unconditionally check it to determine the mode.
Regards,
Loic
next prev parent reply other threads:[~2018-04-26 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 17:59 [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function Loic Poulain
2018-04-23 17:59 ` [PATCH 2/2] Bluetooth: btqca: Add AR3002 rampatch support Loic Poulain
2018-04-24 15:13 ` Marcel Holtmann
2018-04-25 7:58 ` Loic Poulain
2018-04-25 12:16 ` bgodavar
2018-04-25 13:37 ` Loic Poulain
2018-04-25 15:19 ` bgodavar
2018-04-26 6:52 ` Loic Poulain [this message]
2018-04-24 15:10 ` [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function Marcel Holtmann
2018-04-25 10:00 ` Loic Poulain
2018-04-25 12:10 ` Marcel Holtmann
2018-04-25 13:34 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZdPi9=VsrfomPCZURuGApEzakjKjD_8YjHfnO+i4e-1EgMLA@mail.gmail.com' \
--to=loic.poulain@linaro.org \
--cc=bgodavar@codeaurora.org \
--cc=kkapra@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).