From: Loic Poulain <loic.poulain@linaro.org>
To: bgodavar@codeaurora.org
Cc: Marcel Holtmann <marcel@holtmann.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, kkapra@codeaurora.org
Subject: Re: [PATCH 2/2] Bluetooth: btqca: Add AR3002 rampatch support
Date: Wed, 25 Apr 2018 15:37:29 +0200 [thread overview]
Message-ID: <CAMZdPi_khDRySWydoe577Q3vmDFzQY0SBzweJD60026Gb0d8Gw@mail.gmail.com> (raw)
In-Reply-To: <f46651bdc4bdab38ec6f2b00b7fda142@codeaurora.org>
Hi Balakrishna,
On 25 April 2018 at 14:16, <bgodavar@codeaurora.org> wrote:
>
> Thank you for adding me to loop, is the header size of RAM patch file
> remains same for ROME < 3.2 and ROME >= 3.2, what about the header format,
> do we have same header format for different ROME versions, even mismatch of
> header will not break any execution, but it may show wrong data in kernel
> logs.
Yes, at least in my case, we just use byte 7 which was previously 'reserved':
struct edl_event_hdr {
@@ -94,7 +102,8 @@ struct tlv_type_patch {
__le32 data_length;
__u8 format_version;
__u8 signature;
- __le16 reserved1;
+ __u8 download_mode;
+ __u8 reserved1;
__le16 product_id;
__le16 rom_build;
__le16 patch_version;
Regards,
Loic
next prev parent reply other threads:[~2018-04-25 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 17:59 [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function Loic Poulain
2018-04-23 17:59 ` [PATCH 2/2] Bluetooth: btqca: Add AR3002 rampatch support Loic Poulain
2018-04-24 15:13 ` Marcel Holtmann
2018-04-25 7:58 ` Loic Poulain
2018-04-25 12:16 ` bgodavar
2018-04-25 13:37 ` Loic Poulain [this message]
2018-04-25 15:19 ` bgodavar
2018-04-26 6:52 ` Loic Poulain
2018-04-24 15:10 ` [PATCH 1/2] Bluetooth: Add __hci_cmd_sync_noev function Marcel Holtmann
2018-04-25 10:00 ` Loic Poulain
2018-04-25 12:10 ` Marcel Holtmann
2018-04-25 13:34 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZdPi_khDRySWydoe577Q3vmDFzQY0SBzweJD60026Gb0d8Gw@mail.gmail.com \
--to=loic.poulain@linaro.org \
--cc=bgodavar@codeaurora.org \
--cc=kkapra@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).