From: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Lukasz Rymanowski <lukasz.rymanowski@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Szymon Janc <szymon.janc@tieto.com>
Subject: Re: [PATCH] android/gatt: Fix handling advertising state
Date: Wed, 14 May 2014 19:54:49 +0200 [thread overview]
Message-ID: <CAMudyAvYAwFQ1qvDGJBBjQhhJc5FszcwgtbHRhs7SHdA7WwyMA@mail.gmail.com> (raw)
In-Reply-To: <30C3CB2E-2C64-4E1D-8C9F-B4F83704BA8D@holtmann.org>
Hi Marcel
On 14 May 2014 18:10, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Lukasz,
>
>>>> This patch fixes enabling advertising.
>>>> It was not possible to enable it if we had server registered
>>>> which is on listen_apps list but does not trigger advertising.
>>>
>>> does this mean we always advertise when registering GATT server?
>> No. We just put each server on the listen_apps queue and once remote
>> device connects to us, this server gets connection callback.
>
> this sounds all a bit weird. Did Android get this wrong. We can connect to a remote device and we can still receive GATT server exchange. It has really nothing to do with central or peripheral roles.
This is bit weird I agree.
The fact is that if we want to send any read/write request to Android
Server App we need to have connection id for the server. So probably
we need to invoke connection cb for all the servers on any
incoming/outgoing connections. For now we do it only for incoming
connections just for testing. There is no single app using Server HAL
so we don't know how this actually should work.
>
> Regards
>
> Marcel
>
BR
Lukasz
prev parent reply other threads:[~2014-05-14 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 11:26 [PATCH] android/gatt: Fix handling advertising state Lukasz Rymanowski
2014-05-14 13:19 ` Szymon Janc
2014-05-14 15:12 ` Marcel Holtmann
2014-05-14 16:02 ` Lukasz Rymanowski
2014-05-14 16:10 ` Marcel Holtmann
2014-05-14 17:54 ` Lukasz Rymanowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMudyAvYAwFQ1qvDGJBBjQhhJc5FszcwgtbHRhs7SHdA7WwyMA@mail.gmail.com \
--to=lukasz.rymanowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lukasz.rymanowski@gmail.com \
--cc=marcel@holtmann.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).