From: David Herrmann <dh.herrmann@googlemail.com>
To: Scott James Remnant <scott@netsplit.com>
Cc: Bastien Nocera <hadess@hadess.net>,
Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, keybuk@chromium.org
Subject: Re: [RFC PATCHv2] autopair: add autopair plugin
Date: Wed, 15 Feb 2012 18:57:11 +0100 [thread overview]
Message-ID: <CANq1E4ReR544EGPGVV++dH4eWsEL1Hu0rS3v2QDmZHv_fqnJ1w@mail.gmail.com> (raw)
In-Reply-To: <CA+bD78hTvaf92zy0t2xSMO2uoM+xL73XopxrvGbR5uW+6Uc3pw@mail.gmail.com>
Hi Scott
On Tue, Jan 31, 2012 at 12:10 AM, Scott James Remnant
<scott@netsplit.com> wrote:
> On Mon, Jan 30, 2012 at 3:03 PM, Bastien Nocera <hadess@hadess.net> wrote=
:
>> Em Mon, 2012-01-30 =E0s 14:35 -0800, Scott James Remnant escreveu:
>>> On Mon, Jan 30, 2012 at 2:33 PM, Bastien Nocera <hadess@hadess.net> wro=
te:
>>> > Em Mon, 2012-01-30 =E0s 13:42 -0800, Scott James Remnant escreveu:
>>> >> > The PIN length hint is also ignored in the current code:
>>> >> > + =A0 =A0 =A0 <device type=3D"audio" oui=3D"00:1A:80:" name=3D"CMT=
-DH5BT"
>>> >> pin=3D"max:4"/>
>>> >> >
>>> >> Because that's a UI restriction, no?
>>> >>
>>> >> I didn't put any PIN-generation code here, because I'm not entirely
>>> >> sure what the UI for "generate random PIN' should look like or which
>>> >> spec you're following.
>>> >
>>> > It means that a generated PIN shouldn't have more than 4 digits for i=
t
>>> > to work with this device.
>>> >
>>> What generated PIN? Which spec/profile says you have to generate a PIN
>>> for this device?
>>
>> It's recommended that the UIs try to generate PINs for the users, rather
>> than relying on them entering random numbers.
>>
> Recommended where? Can you point at least at the correct document?
>
> The only recommendation I'm aware of is in the HID profile, which
> would not apply here, and strangely you don't use this max: form for
> keyboards which would be the only devices they applied to.
>
>
> The description matches the HID profile behavior I've sumitted as a
> separate set of CLs.
>
Any update on this plugin? It would make the wiimote plugin obsolete
and allow us to select PINs based on device-names.
If you do not intend to continue your work here I will try fixing the
stuff and resubmit it.
Regards
David
next prev parent reply other threads:[~2012-02-15 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 23:47 [RFC PATCHv2] autopair: add autopair plugin Scott James Remnant
2012-01-30 19:49 ` Marcel Holtmann
2012-01-30 20:05 ` Bastien Nocera
2012-01-30 21:42 ` Scott James Remnant
2012-01-30 22:33 ` Bastien Nocera
2012-01-30 22:35 ` Scott James Remnant
2012-01-30 23:03 ` Bastien Nocera
2012-01-30 23:10 ` Scott James Remnant
2012-02-15 17:57 ` David Herrmann [this message]
2012-02-15 19:18 ` Scott James Remnant
2012-01-30 21:40 ` Scott James Remnant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANq1E4ReR544EGPGVV++dH4eWsEL1Hu0rS3v2QDmZHv_fqnJ1w@mail.gmail.com \
--to=dh.herrmann@googlemail.com \
--cc=hadess@hadess.net \
--cc=keybuk@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=scott@netsplit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).