Re: [PATCH] Bluetooth: Fix coding style

[David Herrmann <dh.herrmann@googlemail.com>]

Hi David

On Sun, May 6, 2012 at 6:36 PM, David Miller <davem@davemloft.net> wrote:
> From: Gustavo Padovan <gustavo@padovan.org>
> Date: Fri,  4 May 2012 15:59:48 -0300
>
>> Fix offending styles all over the tree. This is in conformance David
>> Miller's style rules.
>
> They aren't just my style rules.

Whose rules are they?

Reading ./Documentation/CodingStyle I see:
+++++++
Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation, and the above example is deliberately broken.
+++++++

Or looking at the last 3 of Linus' commits that use multi-line
expressions, none of them uses mixed tabs+spaces to have lined-up
indentation (which is what you recommend):

e419b4cc585680940bc42f8ca8a071d6023fb1bb vfs: make word-at-a-time...
6be5ceb02e98eaf6cfc4f8b12a896d04023f340d VM: Add "vm_mmap" helper...
a554bea89948dfb6d2f9c4c62ce2b12b2dac18ad selinux: don't inline...

So why so reluctant to calling it "David's style"?

> And, if your plan is to patch things up afterwards so you don't
> have to change existing commits in your tree, think again.
>
> I absolutely will not pull a tree from John that has commits in
> it that add the bad indentation.
>
> You have to respin your tree with fixed commits.

That's just old code that is reindented. Nothing special. All new
commits use the new coding-style properly.

> The bluetooth folks have to understand that they are on an extremely
> short leash right now.

Regards
David