From: Marcel Holtmann <marcel@holtmann.org>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org, emamd001@umn.edu
Subject: Re: [PATCH] Bluetooth: Fix memory leak in hci_connect_le_scan
Date: Fri, 22 Nov 2019 10:43:24 +0100 [thread overview]
Message-ID: <CBF99933-AF98-4879-B4E1-C5E6153FE2DD@holtmann.org> (raw)
In-Reply-To: <20191121202038.27331-1-navid.emamdoost@gmail.com>
Hi Navid,
> In the implementation of hci_connect_le_scan() when conn is added via
> hci_conn_add(), if hci_explicit_conn_params_set() fails the allocated
> memory for conn is leaked. Use hci_conn_del() to release it.
>
> Fixes: f75113a26008 ("Bluetooth: add hci_connect_le_scan")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> net/bluetooth/hci_conn.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2019-11-22 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 20:20 [PATCH] Bluetooth: Fix memory leak in hci_connect_le_scan Navid Emamdoost
2019-11-22 9:43 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBF99933-AF98-4879-B4E1-C5E6153FE2DD@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox