Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH] Install avinfo utility
Date: Wed, 10 Jun 2020 10:27:25 +0200	[thread overview]
Message-ID: <CECA6D9A-0F26-40E8-BFDF-A24CD972307D@holtmann.org> (raw)
In-Reply-To: <20200506193435.3746-1-pali@kernel.org>

Hi Pali,

> This utility is very useful for determining which A2DP codecs are supported
> by remote side. So install it to system as part of bluez package.
> ---
> Makefile.tools | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.tools b/Makefile.tools
> index 9b9236609..d52721612 100644
> --- a/Makefile.tools
> +++ b/Makefile.tools
> @@ -176,9 +176,9 @@ endif
> if TOOLS
> bin_PROGRAMS += tools/rctest tools/l2test tools/l2ping tools/bccmd \
> 			tools/bluemoon tools/hex2hcd tools/mpris-proxy \
> -			tools/btattach
> +			tools/btattach tools/avinfo
> 
> -noinst_PROGRAMS += tools/bdaddr tools/avinfo tools/avtest \
> +noinst_PROGRAMS += tools/bdaddr tools/avtest \
> 			tools/scotest tools/amptest tools/hwdb \
> 			tools/hcieventmask tools/hcisecfilter \
> 			tools/btinfo tools/btconfig \

I had no intention to install that tool since it is too limited and makes too many assumption. In addition it has a bad name with no Bluetooth prefix.

If we think it is useful to have such a test utility, then we need to clean this up first and put this into a larger btinfo work to gather appropriate information from a remote device for debug purposes.

Regards

Marcel


  parent reply	other threads:[~2020-06-10  8:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 19:34 [PATCH] Install avinfo utility Pali Rohár
2020-06-01 12:58 ` Pali Rohár
2020-06-10  8:27 ` Marcel Holtmann [this message]
2020-06-10  9:33   ` Pali Rohár
2020-06-10 17:31     ` Marcel Holtmann
2020-06-11 12:53       ` Pali Rohár
2020-07-13  9:09         ` Pali Rohár
2020-08-08 13:20           ` Pali Rohár
2020-08-09  5:33             ` Luiz Augusto von Dentz
2020-08-09 15:33               ` Pali Rohár
2020-08-09 18:22                 ` Luiz Augusto von Dentz
2020-08-14  8:01                   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CECA6D9A-0F26-40E8-BFDF-A24CD972307D@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox