public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Fix possible crash on startup
Date: Sun, 12 Oct 2008 21:15:22 +0300	[thread overview]
Message-ID: <FA1352D8-03D2-4979-99A4-5EFE5EB8872E@gmail.com> (raw)
In-Reply-To: <1223766202.31961.868.camel@cookie.hadess.net>

Hi Bastien,

Thanks for the patch. It has been pushed upstream. However, now that I  
looked at the code in question there are several things I have to  
wonder about:
1. Why is the code using sdp_data_get(rec, SDP_SERVER_RECORD_HANDLE)  
instead of rec->handle?
2. Is having the record really mandatory for allowing a device to  
connect? I.e. could we somehow make input_probe() work even if the  
record isn't available?

I think it was either Claudio or Luiz who has been touching this part  
of bluez code recently (at least git-blame shows Claudio being  
responsible for the SDP_SERVER_RECORD_HANDLE thing) so maybe they can  
shed some more light on these issues?

Johan



  reply	other threads:[~2008-10-12 18:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11 23:03 [PATCH] Fix possible crash on startup Bastien Nocera
2008-10-12 18:15 ` Johan Hedberg [this message]
2008-10-13 13:43   ` Luiz Augusto von Dentz
2008-10-13 14:16     ` Bastien Nocera
2008-10-14 18:47       ` Claudio Takahasi
2008-10-14 21:44         ` Claudio Takahasi
2008-10-14 22:51           ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FA1352D8-03D2-4979-99A4-5EFE5EB8872E@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox