Re: [Bluez-devel] Re: some btsco hacks

[Florian Echtler <echtler@fs.tum.de>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 962 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> > Back references to what/where?
> backrefs are parts of the regexp surrounded by (). the matching expression is
> remembered and can be placed in the command string, by \0 \1 etc it turns out.
> I figured them out & noted in the docs.
Ah, I see - I had overlooked that part of the code.

> In keeping with \0 \1 for backrefs in the regexp and \p for pid, the headset
> state should be \s instead of %d. Would you be willing to make that change (or
> I could)?
No problem, see attached patch.

Another question: has anyone experienced the same problem as I have
(the microphone input sometimes generates only noise) or is that 
strictly a bug of my headset?

Yours, Florian
- -- 
Preserve wildlife - pickle a squirrel today!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCf+DS7CzyshGvatgRAmBVAKDfFJndw9pvwYxeENUCDj7gVyTLhwCfXBBS
LXVG5Iht3y0zFJp7REc3VeE=
=r6pM
-----END PGP SIGNATURE-----

[-- Attachment #2: Type: TEXT/PLAIN, Size: 1035 bytes --]

diff -u -r1.25 btsco.c
--- btsco.c	9 May 2005 04:57:29 -0000	1.25
+++ btsco.c	9 May 2005 22:11:43 -0000
@@ -713,10 +713,7 @@
 							int substl = 0;
 							
 							subst = NULL;
-							
-							// add the current sco mode to the command string
-							sysbuf = malloc(strlen(args)+1);
-							sprintf(sysbuf,args,sco_mode);
+							sysbuf = strdup(args);
 							
 							for(i = 0; sysbuf[i]; i++) {
 								if((sysbuf[i] == '\\') && (sysbuf[i + 1] >= '0') && (sysbuf[i + 1] <= '9')) {
@@ -730,6 +727,10 @@
 									subst = malloc(11); /* For potentially 32-bit PIDs */
 									substl = snprintf(subst, 11, "%i", getpid());
 								}
+								if((sysbuf[i] == '\\') && (sysbuf[i + 1] == 's')) {
+									subst = malloc(11); /* same as above, for SCO mode */
+									substl = snprintf(subst, 11, "%d", sco_mode);
+								}
 								if(subst != NULL) {
 									sysbuf = realloc(sysbuf, strlen(sysbuf) + substl - 1);
 									memmove(sysbuf + i + substl, sysbuf + i + 2, strlen(sysbuf) - i - 1);