From: Leon Romanovsky <leon@kernel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
johan.hedberg@gmail.com, luiz.dentz@gmail.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
alok.a.tiwari@oracle.com, hdanton@sina.com,
ilpo.jarvinen@linux.intel.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org,
amitkumar.karwar@nxp.com, rohit.fule@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v2 1/3] serdev: Add method to assert break
Date: Tue, 31 Jan 2023 10:57:23 +0200 [thread overview]
Message-ID: <Y9jX81zJTM9xzDo2@unreal> (raw)
In-Reply-To: <20230130180504.2029440-2-neeraj.sanjaykale@nxp.com>
On Mon, Jan 30, 2023 at 11:35:02PM +0530, Neeraj Sanjay Kale wrote:
> Adds serdev_device_break_ctl() and an implementation for ttyport.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> drivers/tty/serdev/core.c | 11 +++++++++++
> drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++
> include/linux/serdev.h | 6 ++++++
> 3 files changed, 29 insertions(+)
<...>
> +{
> + struct serport *serport = serdev_controller_get_drvdata(ctrl);
> + struct tty_struct *tty = serport->tty;
> +
> + if (!tty->ops->break_ctl)
> + return -ENOTSUPP;
Documentation/dev-tools/checkpatch.rst
429 **ENOTSUPP**
430 ENOTSUPP is not a standard error code and should be avoided in new patches.
431 EOPNOTSUPP should be used instead.
432
433 See: https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/
Thanks
next prev parent reply other threads:[~2023-01-31 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 18:05 [PATCH v2 0/3] Add support for NXP bluetooth chipsets Neeraj Sanjay Kale
2023-01-30 18:05 ` [PATCH v2 1/3] serdev: Add method to assert break Neeraj Sanjay Kale
2023-01-30 18:35 ` Add support for NXP bluetooth chipsets bluez.test.bot
2023-01-31 8:57 ` Leon Romanovsky [this message]
2023-01-31 9:50 ` [PATCH v2 1/3] serdev: Add method to assert break Greg KH
2023-01-30 18:05 ` [PATCH v2 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support Neeraj Sanjay Kale
2023-01-31 1:52 ` Rob Herring
2023-01-31 19:04 ` Krzysztof Kozlowski
2023-01-30 18:05 ` [PATCH v2 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets Neeraj Sanjay Kale
2023-01-30 21:10 ` Luiz Augusto von Dentz
2023-01-31 2:20 ` Rob Herring
2023-02-01 12:33 ` Neeraj sanjay kale
2023-01-31 9:01 ` Leon Romanovsky
2023-01-31 10:00 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9jX81zJTM9xzDo2@unreal \
--to=leon@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=amitkumar.karwar@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rohit.fule@nxp.com \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).