From: Johan Hovold <johan@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bluetooth: fix potential gfp
Date: Fri, 7 May 2021 17:30:44 +0200 [thread overview]
Message-ID: <YJVdJEMKz6YcnwOW@hovoldconsulting.com> (raw)
In-Reply-To: <CDE30B55-E91B-4513-80E4-2198F8A32217@holtmann.org>
On Fri, May 07, 2021 at 05:20:11PM +0200, Marcel Holtmann wrote:
> Hi Johan,
>
> >>> In qca_power_shutdown() qcadev local variable is
> >>> initialized by hu->serdev.dev private data, but
> >>> hu->serdev can be NULL and there is a check for it.
> >>>
> >>> Since, qcadev is not used before
> >>>
> >>> if (!hu->serdev)
> >>> return;
> >>>
> >>> we can move its initialization after this "if" to
> >>> prevent gfp.
> >>>
> >>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> >>> ---
> >>> drivers/bluetooth/hci_qca.c | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> patch has been applied to bluetooth-next tree.
> >
> > Why did you pick the v1 when it is clear from thread that a v2 has been
> > posted?
>
> because I only saw that email after I applied the patch and the v2 is
> nowhere in sight as it seems. If it shows up, I replace this one then.
Here it is
https://lore.kernel.org/lkml/20210503100605.5223-1-paskripkin@gmail.com/
Johan
next prev parent reply other threads:[~2021-05-07 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 15:04 [PATCH] bluetooth: fix potential gfp Pavel Skripkin
2021-05-01 16:14 ` bluez.test.bot
2021-05-03 7:57 ` [PATCH] " Johan Hovold
2021-05-03 8:37 ` Pavel Skripkin
2021-05-03 10:06 ` [PATCH v2] bluetooth: hci_qca: fix potential GPF Pavel Skripkin
2021-05-03 11:13 ` [v2] " bluez.test.bot
2021-05-03 11:22 ` [PATCH v2] " Johan Hovold
2021-05-07 8:27 ` [PATCH] bluetooth: fix potential gfp Marcel Holtmann
2021-05-07 13:11 ` Johan Hovold
2021-05-07 15:20 ` Marcel Holtmann
2021-05-07 15:30 ` Johan Hovold [this message]
2021-05-07 16:07 ` Marcel Holtmann
2021-05-07 16:16 ` Johan Hovold
2021-05-07 19:22 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJVdJEMKz6YcnwOW@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=paskripkin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox