From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC107C433ED for ; Fri, 7 May 2021 16:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BF5E61451 for ; Fri, 7 May 2021 16:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236232AbhEGQQ5 (ORCPT ); Fri, 7 May 2021 12:16:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:39304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236172AbhEGQQ4 (ORCPT ); Fri, 7 May 2021 12:16:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5EF0B6144F; Fri, 7 May 2021 16:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620404156; bh=z5Y9oqMMujVEmM2x7d9pqxvRKUCHL3wnm98CbSGpkio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mg7WuttHYDYfJO2piw9qOGZ7qFyUhiK65mxp/fCO6FcWipwwZuFIVQckZ5nJGqJ5w zefO8jlSgv1UQA+KB6lC65aojteuTR7MaLzl5ZoxjR6/Mrv0JXXU+7KSEG0JfIWYQ7 bEsY9mpnfza+KbE1wbA8XOYoknx8uKNfujvXUGhXRaKwOhyEqjVYckWR2sqihLXpz5 lL0W6q5sFueUCG9ZHPPPd0zmUmjPRcdwoSHKnHjNSFTrz/rg83TCpGeBVqxMEsX9BC GJiEyby3GjMvOdHy9ny5liuOaDC4Lf0c82iKjzc6z1BVuY1KMizhsHy62boh/zTIzH wXlE5251LRJMA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1lf393-0006kU-RK; Fri, 07 May 2021 18:16:06 +0200 Date: Fri, 7 May 2021 18:16:05 +0200 From: Johan Hovold To: Marcel Holtmann Cc: Pavel Skripkin , Johan Hedberg , Luiz Augusto von Dentz , Bluetooth Kernel Mailing List , linux-kernel@vger.kernel.org Subject: Re: [PATCH] bluetooth: fix potential gfp Message-ID: References: <20210501150445.4055-1-paskripkin@gmail.com> <9A08CBDA-3501-48F6-9F7A-60958C5CF888@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Fri, May 07, 2021 at 06:07:50PM +0200, Marcel Holtmann wrote: > Hi Johan, > > >>>>> In qca_power_shutdown() qcadev local variable is > >>>>> initialized by hu->serdev.dev private data, but > >>>>> hu->serdev can be NULL and there is a check for it. > >>>>> > >>>>> Since, qcadev is not used before > >>>>> > >>>>> if (!hu->serdev) > >>>>> return; > >>>>> > >>>>> we can move its initialization after this "if" to > >>>>> prevent gfp. > >>>>> > >>>>> Signed-off-by: Pavel Skripkin > >>>>> --- > >>>>> drivers/bluetooth/hci_qca.c | 4 ++-- > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>> patch has been applied to bluetooth-next tree. > >>> > >>> Why did you pick the v1 when it is clear from thread that a v2 has been > >>> posted? > >> > >> because I only saw that email after I applied the patch and the v2 is > >> nowhere in sight as it seems. If it shows up, I replace this one then. > > > > Here it is > > > > https://lore.kernel.org/lkml/20210503100605.5223-1-paskripkin@gmail.com/ > > seems to have missed my inbox. Fixed now. Would you mind adding my Reviewed-by tag from the reply to that patch as well? I don't know if you're using b4 yet but it can be used to fetch it all from lore. Johan