From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596F4C433EF for ; Wed, 6 Oct 2021 17:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40EF96113A for ; Wed, 6 Oct 2021 17:39:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbhJFRld (ORCPT ); Wed, 6 Oct 2021 13:41:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhJFRl3 (ORCPT ); Wed, 6 Oct 2021 13:41:29 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E9CC061755 for ; Wed, 6 Oct 2021 10:39:37 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id n11so1739487plf.4 for ; Wed, 06 Oct 2021 10:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0wxSw7qisVOunDrqS7f7e7Lry8Q/2GqOFqAP3EHViQE=; b=COvDgniH8rLSITY0sop34UzfIg0DlqGltWATNZ0SwKM8ra7XKVYwhSswDmjxFfnWoB jkXyQ5g81nWBtjk9JV9iBqWz6bjMkkUx6Btx/pafmHt7Yp0WycPstzVublfXjLC38/A/ rVbo6bpML3Fd6rqS7mWwENRjEw5Mz+bU6Y8+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0wxSw7qisVOunDrqS7f7e7Lry8Q/2GqOFqAP3EHViQE=; b=LWzBHp1PRtXpmrV80Cyn/ebxU2kyyTmAFX7ExXO/74UMgdNLzMukrly34wXRFAoyOS VUxluJ6fUU+jkgj/QjaI4oMY3JHETy5iKU6MhbgIaSopUZJnDp9lQ71Mpb45TVPZGE2q RKKo0scA2XwTxjYlhXYUENCVxaQ7l2oEgT0LHZ0Zxr4VDzGYKW0zJg+KIOj+p9QWmuCI N1yZ6EM0kA2cgdvVvTqYQbNQFRd/2VqEWmnKDZZY3Mi0EPdzgbcGs44jwHVAUM8bbSGn XRkJodTXKmpbG6QCTsCBjsZNutRa/esDdlzrfM5d0JOafO6hruUuh5EW4HBgFS2r1xVs HDsw== X-Gm-Message-State: AOAM530/s/GRtRLghK3ZvaAdyAJLPxDlxIKBqU4l09qAA/3pI53/c+Pz 2m8ucTK7GP2mlaRFK8tRBKR3fg== X-Google-Smtp-Source: ABdhPJwcHEgZhjlJeUc2eGnkpbuDa8JMMBuwvTTpop0E/nxpp6bhbr/QT6/qllxHfPV3wROn0Dgjbw== X-Received: by 2002:a17:90b:390d:: with SMTP id ob13mr38595pjb.50.1633541976756; Wed, 06 Oct 2021 10:39:36 -0700 (PDT) Received: from localhost ([2620:15c:202:201:a463:ae21:d1fc:ddfd]) by smtp.gmail.com with UTF8SMTPSA id 11sm20751156pfl.41.2021.10.06.10.39.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 10:39:36 -0700 (PDT) Date: Wed, 6 Oct 2021 10:39:34 -0700 From: Matthias Kaehlcke To: Balakrishna Godavarthi Cc: marcel@holtmann.org, bjorn.andersson@linaro.org, johan.hedberg@gmail.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, rjliao@codeaurora.org, pharish@codeaurora.org, abhishekpandit@chromium.org Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board Message-ID: References: <1633523403-32264-1-git-send-email-bgodavar@codeaurora.org> <1633523403-32264-2-git-send-email-bgodavar@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1633523403-32264-2-git-send-email-bgodavar@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Wed, Oct 06, 2021 at 06:00:03PM +0530, Balakrishna Godavarthi wrote: > Subject: arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board Not super helpful, what does 'update' mean? It might be easier to have a single patch for both IDP boards, since the Bluetooth node is added in the common sc7280-idp.dtsi board, rather than explaining what this patch does :) > This patch updates bluetooth node in SC7280 IDP2 board. > > Signed-off-by: Balakrishna Godavarthi > --- > arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts > index 1fc2add..5c8d54b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts > @@ -15,9 +15,15 @@ > > aliases { > serial0 = &uart5; > + bluetooth0 = &bluetooth; > + hsuart0 = &uart7; > }; Sort aliases alphabetically > > chosen { > stdout-path = "serial0:115200n8"; > }; > }; > + > +&bluetooth: wcn6750-bt { &bluetooth { > + vddio-supply = <&vreg_l18b_1p8>; nit: if it's not really common across IDP boards or a default, you could leave it unconfigured in sc7280-idp.dtsi, and set in both board files. Just an idea, with only two boards it doesn't really matter too much.