From: Matthias Kaehlcke <mka@chromium.org>
To: Panicker Harish <quic_pharish@quicinc.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
quic_hemantg@quicinc.com, linux-arm-msm@vger.kernel.org,
quic_bgodavar@quicinc.com, rjliao@codeaurora.org,
hbandi@codeaurora.org, abhishekpandit@chromium.org,
mcchou@chromium.org, quic_saluvala@quicinc.com
Subject: Re: [PATCH v3] Bluetooth: hci_qca: Stop IBS timer during BT OFF
Date: Tue, 14 Dec 2021 09:22:46 -0800 [thread overview]
Message-ID: <YbjS5sPkiyfl42np@google.com> (raw)
In-Reply-To: <1639484691-28202-1-git-send-email-quic_pharish@quicinc.com>
On Tue, Dec 14, 2021 at 05:54:51PM +0530, Panicker Harish wrote:
> The IBS timers are not stopped properly once BT OFF is triggered.
> we could see IBS commands being sent along with version command,
> so stopped IBS timers while Bluetooth is off.
>
> Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")
>
> Signed-off-by: Panicker Harish <quic_pharish@quicinc.com>
> ---
> drivers/bluetooth/hci_qca.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index dd768a8..6f44b26 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
> hu->hdev->hw_error = NULL;
> hu->hdev->cmd_timeout = NULL;
>
> + mod_timer(&qca->tx_idle_timer, 0);
> + mod_timer(&qca->wake_retrans_timer, 0);
> +
If one of the timers is already running it wouldn't be stopped by mod_timer().
I think you want a del_timer_sync() here to ensure the timers aren't running
when the chip is powered off.
next prev parent reply other threads:[~2021-12-14 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 12:24 [PATCH v3] Bluetooth: hci_qca: Stop IBS timer during BT OFF Panicker Harish
2021-12-14 17:22 ` Matthias Kaehlcke [this message]
2021-12-21 4:52 ` PANICKER HARISH (Temp) (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbjS5sPkiyfl42np@google.com \
--to=mka@chromium.org \
--cc=abhishekpandit@chromium.org \
--cc=hbandi@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_hemantg@quicinc.com \
--cc=quic_pharish@quicinc.com \
--cc=quic_saluvala@quicinc.com \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox