Re: [PATCH v8 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855

Johan Hovold
2023-03-30T10:10:49Z

On Sun, Mar 26, 2023 at 06:38:10PM -0500, Steev Klimaszewski wrote:
> Add regulators, GPIOs and changes required to power on/off wcn6855.
> Add support for firmware download for wcn6855 which is in the
> linux-firmware repository as hpbtfw21.tlv and hpnv21.bin.
>
> Based on the assumption that this is similar to the wcn6750
>
> Tested-on: BTFW.HSP.2.1.0-00538-VER_PATCHZ-1
>
> Signed-off-by: Steev Klimaszewski <steev@kali.org>
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> Tested-by: Bjorn Andersson <andersson@kernel.org>
> ---
> Changes since v7:
> * None

Only noticed now when Luiz applied the patches, but why did you drop my
reviewed-by and tested-by tags from this patch when submitting v8?

For the record:

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Johan Hovold <johan+linaro@kernel.org>

> Changes since v6:
> * Update commit message.
> * Add Johan's R-b and T-b.
>
> Changes since v5:
> * Revert Set qcadev->initspeed since 6855 doesn't use it, don't touch.
> * Convert get_fw_build_info to a switch statement
> * Add poweroff handling
> * Fix up line alignments
> * Drop from microsoft extensions check since I don't actually know if we need
>
> Changes since v4:
> * Remove unused firmware check because we don't have mbn firmware.
> * Set qcadev->init_speed if it hasn't been set.
>
> Changes since v3:
> * drop unused regulators
>
> Changes since v2:
> * drop unnecessary commit info
>
> Changes since v1:
> * None

Johan