From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8DA1DFE8; Wed, 27 Dec 2023 18:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z+okM2UP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7BF2C433C7; Wed, 27 Dec 2023 18:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703702157; bh=0siblmpSE3KVqzpkVehEyjAK/TXGvMOcCY6Sg22LjFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+okM2UPtZvpqDe2UxBEUhMFMY05kH1/mlKCbek+O2bzesZLs7yZVmy1hcDhscxY6 5oUBNI9vp6zmRW9vu8ZmOHdWiKuqpM7UZoiojjcQqamytmNifU3mqaOKez4TsRNLp7 /VJ5LXD5VLWeNb2N8vrNnWeaffF4jpDPCfIQ0HpR9G41q5NYbH6J/pyijpIMkc4tBH 7LF1nsxObXxnsbPOGNyvpLFY4mShT1jzpD+cRw5TdiklWxDKe2Y63Vkoic74VxLpbf 1qR/pfaGdQxMkKAiduWwWmdhqnFd/GLZBen4weUNLoc+RlWnQn8v27yrnOOSuRq4qy KGPhIUqlsFXXA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rIYkz-00024a-0q; Wed, 27 Dec 2023 19:35:53 +0100 Date: Wed, 27 Dec 2023 19:35:53 +0100 From: Johan Hovold To: Felix Zhang Cc: Johan Hovold , Luiz Augusto von Dentz , Marcel Holtmann , Johan Hedberg , Hector Martin , Sven Peter , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_bcm4377: do not mark valid bd_addr as invalid Message-ID: References: <20231227101003.10534-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 27, 2023 at 01:19:39PM -0500, Felix Zhang wrote: > On Wed, 2023-12-27 at 11:10 +0100, Johan Hovold wrote: > > A recent commit restored the original (and still documented) > > semantics > > for the HCI_QUIRK_USE_BDADDR_PROPERTY quirk so that the device > > address > > is considered invalid unless an address is provided by firmware. > > > > This specifically means that this flag must only be set for devices > > with > > invalid addresses, but the Broadcom BCM4377 driver has so far been > > setting this flag unconditionally. > > > > Fortunately the driver already checks for invalid addresses during > > setup > > and sets the HCI_QUIRK_INVALID_BDADDR flag, which can simply be > > replaced > > with HCI_QUIRK_USE_BDADDR_PROPERTY to indicate that the default > > address > > is invalid but can be overridden by firmware (long term, this should > > probably just always be allowed). > > > > Fixes: 6945795bc81a ("Bluetooth: fix use-bdaddr-property quirk") > > Cc: stable@vger.kernel.org      # 6.5 > > Reported-by: Felix Zhang > > Link: > > https://lore.kernel.org/r/77419ffacc5b4875e920e038332575a2a5bff29f.camel@mrman314.tech/ > > Signed-off-by: Johan Hovold > Thanks for the patch! I have just tested the patch on my MacBookAir9,1 > with some modifications to make it patch with the master branch of the > Linux kernel, and it works great! The device is recognized by the > system; and I can scan, pair, connect, and play audio just fine. If > you want me to send over the modified patch that I have used, please > let me know. Thanks for confirming. You should not need to modify the patch, though, as it has been created against 6.7-rc6 and there hasn't been any changes to this driver since rc1. Johan