From: Johan Hovold <johan@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Matthias Kaehlcke <mka@chromium.org>,
Rocky Liao <quic_rjliao@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: bluetooth: add 'qcom,local-bd-address-broken'
Date: Tue, 19 Mar 2024 17:22:38 +0100 [thread overview]
Message-ID: <Zfm7zjD-aicgvr-t@hovoldconsulting.com> (raw)
In-Reply-To: <CAD=FV=XJ+yAvDn5NyfCSJdg+DujPrWO+DZu=BmcqbJS-ugEGMg@mail.gmail.com>
On Tue, Mar 19, 2024 at 09:10:08AM -0700, Doug Anderson wrote:
> On Tue, Mar 19, 2024 at 8:29 AM Johan Hovold <johan+linaro@kernel.org> wrote:
> > + qcom,local-bd-address-broken: true
> > + description: >
> > + boot firmware is incorrectly passing the address in big-endian order
>
> Personally, I feel like "qcom,local-bd-address-backwards" or
> "qcom,local-bd-address-swapped" would be more documenting but I don't
> feel super strongly about it. I guess "broken" makes it more obvious
> that this is not just a normal variant that someone should use.
Yeah, that is precisely why I chose that name, to avoid having people
think this is something they can just pick and choose for their driver.
As is repeatedly made clear, this needs to be obvious from the name, as
apparently not many people bother to look up the documentation.
> If DT binding folks are happy, I'm happy enough with this solution.
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks for reviewing.
Johan
next prev parent reply other threads:[~2024-03-19 16:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 15:29 [PATCH v3 0/5] Bluetooth: qca: fix device-address endianness Johan Hovold
2024-03-19 15:29 ` [PATCH v3 1/5] dt-bindings: bluetooth: add 'qcom,local-bd-address-broken' Johan Hovold
2024-03-19 15:37 ` Bluetooth: qca: fix device-address endianness bluez.test.bot
2024-03-19 16:10 ` [PATCH v3 1/5] dt-bindings: bluetooth: add 'qcom,local-bd-address-broken' Doug Anderson
2024-03-19 16:22 ` Johan Hovold [this message]
2024-03-19 20:02 ` Rob Herring
2024-03-19 15:29 ` [PATCH v3 2/5] Bluetooth: add quirk for broken address properties Johan Hovold
2024-03-19 16:10 ` Doug Anderson
2024-03-19 16:16 ` Konrad Dybcio
2024-03-19 16:26 ` Johan Hovold
2024-03-19 17:01 ` Dmitry Baryshkov
2024-03-19 17:38 ` Johan Hovold
2024-03-19 17:02 ` Luiz Augusto von Dentz
2024-03-19 17:04 ` Luiz Augusto von Dentz
2024-03-19 15:29 ` [PATCH v3 3/5] Bluetooth: qca: fix device-address endianness Johan Hovold
2024-03-19 16:10 ` Doug Anderson
2024-03-19 16:38 ` Johan Hovold
2024-03-19 17:12 ` Doug Anderson
2024-03-19 17:28 ` Johan Hovold
2024-03-19 17:33 ` Doug Anderson
2024-03-19 15:29 ` [PATCH v3 4/5] Bluetooth: qca: add workaround for broken address properties Johan Hovold
2024-03-19 15:29 ` [PATCH v3 5/5] arm64: dts: qcom: sc7180-trogdor: mark bluetooth address as broken Johan Hovold
2024-03-19 16:10 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfm7zjD-aicgvr-t@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).