Re: [PATCH v1] Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync

[Janne Grunau <j@jannau.net>]

[-- Attachment #1: Type: text/plain, Size: 3164 bytes --]

On Thu, May 09, 2024 at 12:30:21PM -0400, Luiz Augusto von Dentz wrote:
> Hi Janne,
> 
> On Thu, May 9, 2024 at 12:06 PM Janne Grunau <j@jannau.net> wrote:
> >
> > Hej,
> >
> > On Fri, Apr 05, 2024 at 04:40:33PM -0400, Luiz Augusto von Dentz wrote:
> > > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > >
> > > The extended advertising reports do report the PHYs so this store then
> > > in hci_conn so it can be later used in hci_le_ext_create_conn_sync to
> > > narrow the PHYs to be scanned since the controller will also perform a
> > > scan having a smaller set of PHYs shall reduce the time it takes to
> > > find and connect peers.
> > >
> > > Fixes: 288c90224eec ("Bluetooth: Enable all supported LE PHY by default")
> >
> > This commit in v6.8.9 apparently has regressed connecting to LE devices
> > like Logitech mices with Apple/Broadcom BCM4388 devices. Those devices
> > carry HCI_QUIRK_BROKEN_LE_CODED which became necessary after 288c90224eec
> > ("Bluetooth: Enable all supported LE PHY by default").
> > Tested so far only by reverting aaf06285498861d6caaff5b26d30af70dd2b819f
> > on top of v6.8.9. Looking at the change I don't see anything obvious
> > which would explain the breakage.
> > I would assume v6.9-rc6 is affected as well but I haven't tested this
> > yet.
> 
> Would be great if you provide the HCI trace to confirm the problem.

looks like there is an issue with initiating "LE Extended Create
Connection":

| > HCI Event: LE Meta Event (0x3e) plen 26
|       LE Extended Advertising Report (0x0d)
|         Num reports: 1
|         Entry 0
|           Event type: 0x2515
|             Props: 0x0015
|               Connectable
|               Directed
|               Use legacy advertising PDUs
|             Data status: Complete
|             Reserved (0x2500)
|          Legacy PDU Type: Reserved (0x2515)
|           Address type: Random (0x01)
|           Address: DF:F4:9E:F3:A9:72 (Static)
|           Primary PHY: Reserved
|           Secondary PHY: No packets
|           SID: no ADI field (0xff)
|           TX power: 127 dBm
|           RSSI: -60 dBm (0xc4)
|           Periodic advertising interval: 0.00 msec (0x0000)
|           Direct address type: Public (0x00)
|           Direct address: 5C:1B:F4:7F:BF:6B (Apple, Inc.)
|           Data length: 0x00
| < HCI Command: LE Set Extended Scan Enable (0x08|0x0042) plen 6
|         Extended scan: Disabled (0x00)
|         Filter duplicates: Disabled (0x00)
|         Duration: 0 msec (0x0000)
|         Period: 0.00 sec (0x0000)
| > HCI Event: Command Complete (0x0e) plen 4
|       LE Set Extended Scan Enable (0x08|0x0042) ncmd 1
|         Status: Success (0x00)
| < HCI Command: LE Extended Create Connection (0x08|0x0043) plen 10
|         Filter policy: Accept list is not used (0x00)
|         Own address type: Public (0x00)
|         Peer address type: Random (0x01)
|         Peer address: DF:F4:9E:F3:A9:72 (Static)
|         Initiating PHYs: 0x00
| > HCI Event: Command Status (0x0f) plen 4
|       LE Extended Create Connection (0x08|0x0043) ncmd 1
|        Status: Unsupported Feature or Parameter Value (0x11)

Full trace attached

Janne

[-- Attachment #2: bcm4388_v6.8.9_hci_bt_le.log --]
[-- Type: application/octet-stream, Size: 8711 bytes --]