From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: marcel@holtmann.org, luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org, sre@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth/nokia: Remove unused struct 'hci_nokia_radio_hdr'
Date: Thu, 23 May 2024 15:08:27 +0000 [thread overview]
Message-ID: <Zk9b683tsQrDCjl0@gallifrey> (raw)
In-Reply-To: <20240509001138.204427-1-linux@treblig.org>
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'hci_nokia_radio_hdr' looks like it was unused since it's
> initial commit.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping?
I see a message from the bot asking for a change to the header
which I think wants Bluetooth: nokia: ?
(But then a load of segfaults in the test scripts).
Anything else?
Dave
> ---
> drivers/bluetooth/hci_nokia.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
> index 97da0b2bfd17e..62633d9ba7c43 100644
> --- a/drivers/bluetooth/hci_nokia.c
> +++ b/drivers/bluetooth/hci_nokia.c
> @@ -116,11 +116,6 @@ struct hci_nokia_neg_evt {
> #define SETUP_BAUD_RATE 921600
> #define INIT_BAUD_RATE 120000
>
> -struct hci_nokia_radio_hdr {
> - u8 evt;
> - u8 dlen;
> -} __packed;
> -
> struct nokia_bt_dev {
> struct hci_uart hu;
> struct serdev_device *serdev;
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-05-23 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 0:11 [PATCH] Bluetooth/nokia: Remove unused struct 'hci_nokia_radio_hdr' linux
2024-05-09 1:06 ` bluez.test.bot
2024-05-23 15:08 ` Dr. David Alan Gilbert [this message]
2024-05-23 16:10 ` [PATCH] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk9b683tsQrDCjl0@gallifrey \
--to=linux@treblig.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).