From: Bastien Nocera <hadess@hadess.net>
To: Thomas Kirschner <thomaskirschner85@yahoo.de>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names
Date: Thu, 07 May 2026 10:13:04 +0200 [thread overview]
Message-ID: <a506942c64fea3ff40abe16756de20ee4f426ee2.camel@hadess.net> (raw)
In-Reply-To: <20260506230051.27436-1-thomaskirschner85@yahoo.de>
LGTM
On Thu, 2026-05-07 at 01:00 +0200, Thomas Kirschner wrote:
> MinimumDelay and PreferredMinimumDelay had wrong spelling, causing
> them to be exposed incorrectly over D-Bus. Any client relying on
> the correct spelling would fail to find these entries, breaking
> LE Audio QoS negotiation.
> ---
> profiles/audio/bap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
> index 5333267f7..b35542488 100644
> --- a/profiles/audio/bap.c
> +++ b/profiles/audio/bap.c
> @@ -432,11 +432,11 @@ static gboolean get_qos(const
> GDBusPropertyTable *property,
> dict_append_entry(&dict, "Retransmissions", DBUS_TYPE_BYTE,
> &qos->rtn);
> dict_append_entry(&dict, "MaximumLatency", DBUS_TYPE_UINT16,
> &qos->latency);
> - dict_append_entry(&dict, "MimimumDelay", DBUS_TYPE_UINT32,
> + dict_append_entry(&dict, "MinimumDelay", DBUS_TYPE_UINT32,
> &qos->pd_min);
> dict_append_entry(&dict, "MaximumDelay", DBUS_TYPE_UINT32,
> &qos->pd_max);
> - dict_append_entry(&dict, "PreferredMimimumDelay",
> DBUS_TYPE_UINT32,
> + dict_append_entry(&dict, "PreferredMinimumDelay",
> DBUS_TYPE_UINT32,
> &qos->ppd_min);
> dict_append_entry(&dict, "PreferredMaximumDelay",
> DBUS_TYPE_UINT32,
> &qos->ppd_max);
next prev parent reply other threads:[~2026-05-07 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260506230051.27436-1-thomaskirschner85.ref@yahoo.de>
2026-05-06 23:00 ` [PATCH BlueZ] bap: Fix typo in QoS D-Bus dictionary entry names Thomas Kirschner
2026-05-07 0:58 ` [BlueZ] " bluez.test.bot
2026-05-07 8:13 ` Bastien Nocera [this message]
2026-05-07 17:50 ` [PATCH BlueZ] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a506942c64fea3ff40abe16756de20ee4f426ee2.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=thomaskirschner85@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox