From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Jiri Kosina" <jikos@jikos.cz>
Cc: chris@pcburn.com, linux-kernel@vger.kernel.org,
"Marcel Holtmann" <marcel@holtmann.org>,
bluez-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: Getting make net/built-in.o Error with 2.6.21.1 Build
Date: Tue, 8 May 2007 09:05:39 -0700 [thread overview]
Message-ID: <a781481a0705080905l609dc925s93357e6eb0d4c318@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705081740550.16923@twin.jikos.cz>
Hi Jiri,
On 5/8/07, Jiri Kosina <jikos@jikos.cz> wrote:
> On Tue, 8 May 2007, Satyam Sharma wrote:
>
> > > CC init/version.o
> > > LD init/built-in.o
> > > LD .tmp_vmlinux1
> > > net/built-in.o: In function `hidp_add_connection':
> > > (.text+0x8bb08): undefined reference to `hid_ff_init'
> > > make: *** [.tmp_vmlinux1] Error 1
> > You've got CONFIG_BT_HIDP=y there but CONFIG_USB_HID=m. The trivial
> > patch below solves it. To test, you can just "make oldconfig" on the
> > same .config that broke above and then proceed to make bzImage.
>
> I'd say we need a different fix here. First, the question is whether there
> are any force-feedback devices, supported by USBHID force-feedback layer,
> which have a bluetooth version?
>
> If there are none of them, we could just drop the FF initialization
> completely for now.
>
> On the other hand if there are such devices, just calling hid_ff_init() is
> presently not enough anyway, as the force feedback drivers for HID devices
> are currently USB-transport specific.
Sure, my aim here was to only solve the _build breakage_ by fixing the
Kconfig for this module (that used code from another kernel module
without listing it in its dependencies). If, as you say, the real
solution is that we should actually be taking out the offending call
to the other module itself, then please go ahead -- I don't know much
about the Bluetooth / HIDP subsytem anyway.
Thanks,
Satyam
next prev parent reply other threads:[~2007-05-08 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <463FB6B0.3070005@pcburn.com>
[not found] ` <a781481a0705071725i1d802dfejbcdaca4ab0a1ff55@mail.gmail.com>
2007-05-08 15:49 ` Getting make net/built-in.o Error with 2.6.21.1 Build Jiri Kosina
2007-05-08 16:05 ` Satyam Sharma [this message]
2007-05-08 16:23 ` Jiri Kosina
2007-05-08 16:48 ` [Bluez-devel] " Marcel Holtmann
2007-05-08 17:47 ` Jiri Kosina
2007-05-08 17:50 ` [Bluez-devel] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0705080905l609dc925s93357e6eb0d4c318@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=bluez-devel@lists.sourceforge.net \
--cc=chris@pcburn.com \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox