Re: [PATCH] Do not start mpris-proxy for system users

[Andrew Sayers <kernel.org@pileofstuff.org>]

On Mon, Jun 02, 2025 at 09:37:20PM -0600, Antonio Russo wrote:
> A default installation of bluez results in the systemd user unit
> mpris-proxy.service being started for all users---including root.
> This unnecessarily exposes system users to any security
> vulnerabilities in mpris-proxy.
> 
> Inhibit this default behavior by using ConditionUser=!@system.
> 
> Signed-off-by: Antonio Enrico Russo <aerusso@aerusso.net>
> ---
>  tools/mpris-proxy.service.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/mpris-proxy.service.in b/tools/mpris-proxy.service.in
> index c49d255..6ae56c6 100644
> --- a/tools/mpris-proxy.service.in
> +++ b/tools/mpris-proxy.service.in
> @@ -4,6 +4,7 @@ Documentation=man:mpris-proxy(1)
>  
>  Wants=dbus.socket
>  After=dbus.socket dbus.service
> +ConditionUser=!@system
>  
>  [Service]
>  Type=simple

Reviewed-by: Andrew Sayers <kernel.org@pileofstuff.org>

There was a question earlier in the thread about how to acknowledge me.
I believe the protocol is to use "Suggested-By:" when I haven't replied,
and I assume the "Reviewed-By" line *replaces* it now I have.
But I could be wrong, and don't personally have any important requirements.

> -- 
> 2.49.0
> 
>