From: Remi Pommarel <repk@triplefau.lt>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] policy: Fix reset Control/Target/HS retry counters
Date: Tue, 27 May 2025 15:31:55 +0200 [thread overview]
Message-ID: <aDW-y1WUsWBpcvJ5@pilgrim> (raw)
In-Reply-To: <CABBYNZLzaOJAQROkLCMWv1_OF6JOFcDN2+Aa=f_Rt9ZS7GJCQg@mail.gmail.com>
On Tue, May 27, 2025 at 09:00:51AM -0400, Luiz Augusto von Dentz wrote:
> Hi Remi,
>
> On Mon, May 26, 2025 at 3:52 PM Remi Pommarel <repk@triplefau.lt> wrote:
> >
> > Control and Target retries counter were reset when service state
> > goes from CONNECTED to DISCONNECTED, but usually an extra DISCONNECTING
> > state is reach before going to DISCONNECTED. This causes retry counter
> > to not being reset in this case, leading to service not being able to
> > initialize on next connection. HS retry counter was only reset when
> > limit is reached.
> >
> > Reset the counter as soon as CONNECTED state is reached to avoid that.
>
> Looks correct, but shouldn't we update for other services as well? Not
> just HS and CT and TG.
Thats right, looks like I missed sink and source retry counters.
Thanks
--
Remi
prev parent reply other threads:[~2025-05-27 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 19:43 [PATCH BlueZ] policy: Fix reset Control/Target/HS retry counters Remi Pommarel
2025-05-26 21:13 ` [BlueZ] " bluez.test.bot
2025-05-27 13:00 ` [PATCH BlueZ] " Luiz Augusto von Dentz
2025-05-27 13:31 ` Remi Pommarel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDW-y1WUsWBpcvJ5@pilgrim \
--to=repk@triplefau.lt \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox