Re: [PATCH] Implements the OBEX server/SyncML client binding for syncEvolution (http://syncevolution.org/).

Zhao Forrest
2009-10-21T01:26:00Z

>>>
>>>> +       if (option_syncevolution == TRUE) {
>>>> +               services |= OBEX_SYNCEVOLUTION;
>>>> +               bluetooth_init(OBEX_SYNCEVOLUTION, "OBEX server for"
>>>> +                               " Syncevolution client", NULL,
>>>> +                               SYNCEVOLUTION_CHANNEL, TRUE, FALSE, FALSE,
>>>> +                               NULL);
>>>> +       }
>>>> +
>>>
>>> Which string is going to appear in the service description (the SDP
>>> part)? This one here? Mentioning "SyncML" would be useful. So I suggest
>>> "OBEX server for SyncML, using SyncEvolution". Leave out the
>>> "SyncEvolution client", because the term client is a) overloaded
>>> (SyncML/OBEX/D-Bus) and b) SyncEvolution could be both client and server
>>> in this context (SAN => SyncML client, SyncML message => SyncML server).
>>>
>> OK. Will expose service name as "OBEX server for SyncML, using SyncEvolution"
>> since ProviderName attribute is not supported by obexd now.
>
> If it's consensus the right way would be exposing SyncEvolution
> through ProviderName, please add a comment to the code telling that,
> so someone remember to fix it by the time obexd supports it.
>
Thank you for reminding. A FIXME comment will be put here.