From: Zhao Forrest <forrest.zhao@gmail.com>
To: Forrest Zhao <forrest.zhao@intel.com>,
linux-bluetooth@vger.kernel.org, forrest.zhao@gmail.com
Subject: Re: [PATCH] Check modem_obj_path is not NULL
Date: Mon, 29 Mar 2010 15:58:02 +0800 [thread overview]
Message-ID: <ac8af0be1003290058w3dfa8784h30db54c08f56a38e@mail.gmail.com> (raw)
In-Reply-To: <20100329073957.GA20677@jh-x301>
>> @@ -311,6 +315,10 @@ void telephony_transmit_dtmf_req(void *telephony_device, char tone)
>>
>> debug("telephony-ofono: transmit dtmf: %c", tone);
>>
>> + if (!modem_obj_path)
>> + telephony_transmit_dtmf_rsp(telephony_device,
>> + CME_ERROR_AG_FAILURE);
>> +
>> tone_string = g_strdup_printf("%c", tone);
>> ret = send_method_call(OFONO_BUS_NAME, modem_obj_path,
>
> This doesn't look right. You report an error but still proceed in the
> functions (which will later try to access modem_obj_path). I guess you
> should return from the functions in both of these if-clauses.
>
My bad. Will send out the updated patch ASAP.
prev parent reply other threads:[~2010-03-29 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 20:32 [PATCH] Check modem_obj_path is not NULL Forrest Zhao
2010-03-29 7:39 ` Johan Hedberg
2010-03-29 7:58 ` Zhao Forrest [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8af0be1003290058w3dfa8784h30db54c08f56a38e@mail.gmail.com \
--to=forrest.zhao@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).