linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Gustavo Padovan <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: hci_bcm: Add support for BCM2E7E
Date: Mon, 2 Oct 2017 17:29:10 +0200	[thread overview]
Message-ID: <aed714df-ec91-cda6-c8fc-f45e40c4a6cb@redhat.com> (raw)
In-Reply-To: <20171001103509.4jqlt6kuqgxlm5m5@earth>

Hi,

On 01-10-17 12:35, Sebastian Reichel wrote:
> Hi Hans,
> 
> On Sun, Oct 01, 2017 at 11:27:45AM +0200, Hans de Goede wrote:
>> This will happen automatically with this patch series,
>> but with the current 4.14 bluetooth stack it will work in
>> USB mode, and if we then merge this series post 4.14
>> bluetooth will stop working without users doing a btattach
>> command from userspace and we will have a regression on
>> our hands.
> 
> Once the series from Frédéric Danis lands, you can get
> serial based broadcom bluetooth without btattach:
> 
> https://www.spinics.net/lists/linux-bluetooth/msg71856.html

Oh, cool. Thank you for pointing this out to me. I still
believe reverting the workaround for the 0000:0000
usb-id device is the right thing to do though.

I've tested Frédéric Danis' series and it needed quite
some work on one of my devices. I've just submitted
a 9 patch series to add all the features the platform
code paths of hci_bcm.c have and which were missing from
the serdev code paths.

Regards,

Hans

  reply	other threads:[~2017-10-02 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 20:25 [PATCH 1/2] Bluetooth: btbcm: Add entry for BCM4356A2 UART bluetooth Hans de Goede
2017-09-07 20:25 ` [PATCH 2/2] Bluetooth: hci_bcm: Add support for BCM2E7E Hans de Goede
2017-10-01  9:27   ` Hans de Goede
2017-10-01 10:35     ` Sebastian Reichel
2017-10-02 15:29       ` Hans de Goede [this message]
2017-10-04 19:07         ` Marcel Holtmann
2017-10-05  7:46           ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aed714df-ec91-cda6-c8fc-f45e40c4a6cb@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).