Linux bluetooth development
 help / color / mirror / Atom feed
From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
	rshaffer@codeaurora.org, gustavo@padovan.org
Subject: [PATCH] Use a valid PSM as the default in l2test.
Date: Fri, 8 Oct 2010 08:16:42 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1010080809510.31147@linux-sea-02> (raw)



---------- Forwarded message ----------
Date: Wed, 4 Aug 2010 15:31:13 -0700
From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, johan.hedberg@gmail.com, rshaffer@codeaurora.org,
     Mat Martineau <mathewm@codeaurora.org>
Subject: [PATCH] Use a valid PSM as the default in l2test.

The Bluetooth spec requires PSMs to be odd numbers, with the least
significant bit of the most significant byte set to 0.  This
change is a prerequisite for PSM validation in the kernel.
---
  test/l2test.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/test/l2test.c b/test/l2test.c
index 0bb46f3..32cd27a 100644
--- a/test/l2test.c
+++ b/test/l2test.c
@@ -87,7 +87,7 @@ static long buffer_size = 2048;

  /* Default addr and psm */
  static bdaddr_t bdaddr;
-static unsigned short psm = 10;
+static unsigned short psm = 0x1001;

  /* Default number of frames to send (-1 = infinite) */
  static int num_frames = -1;
-- 
1.7.1


Ping.  Marcel requested this patch to go with the "Validate PSM values 
in calls to connect() and bind()" change to the kernel code.


--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

             reply	other threads:[~2010-10-08 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 15:16 Mat Martineau [this message]
2010-10-09  8:09 ` [PATCH] Use a valid PSM as the default in l2test Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2010-08-04 22:31 Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1010080809510.31147@linux-sea-02 \
    --to=mathewm@codeaurora.org \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=rshaffer@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox