Linux bluetooth development
 help / color / mirror / Atom feed
From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org
Cc: padovan@profusion.mobi, pkrystad@codeaurora.org
Subject: Re: [PATCH 0/2] Bug fixes for RFCOMM and L2CAP
Date: Fri, 16 Dec 2011 15:58:27 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1112161557170.24351@mathewm-linux> (raw)
In-Reply-To: <1323217407-2490-1-git-send-email-mathewm@codeaurora.org>


Gustavo -

On Tue, 6 Dec 2011, Mat Martineau wrote:

> Here are two bug fixes for
> git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth.git
>
> The first is a pretty obvious fix where an RFCOMM disconnect timer
> needs to be cancelled when the disconnect happens earlier.  It's not
> clear why the reference counting logic breaks down if this timer is
> not cancelled, but it's definitely more correct to cancel the timer.
>
> The L2CAP fix came up due to a buggy PTS test, which was not sending
> the L2CAP RFC option in an ERTM config response.  This was causing
> access to uninitialized data.
>
> Mat Martineau (2):
>  Bluetooth: Clear RFCOMM session timer when disconnecting last channel
>  Bluetooth: Prevent uninitialized data access in L2CAP configuration
>
> net/bluetooth/l2cap_core.c  |   16 +++++++++++++++-
> net/bluetooth/rfcomm/core.c |    1 +
> 2 files changed, 16 insertions(+), 1 deletions(-)
>
> -- 
> 1.7.8

Did you get a chance to look at these patches?  Note that there is a 
v2 patch for the L2CAP fix.  They fix uninitialized data access and an 
RFCOMM panic.

--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum


      parent reply	other threads:[~2011-12-16 23:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07  0:23 [PATCH 0/2] Bug fixes for RFCOMM and L2CAP Mat Martineau
2011-12-07  0:23 ` [PATCH 1/2] Bluetooth: Clear RFCOMM session timer when disconnecting last channel Mat Martineau
2011-12-08  8:25   ` Marcel Holtmann
2011-12-08 16:57     ` Mat Martineau
2011-12-08 22:13       ` Marcel Holtmann
2011-12-07  0:23 ` [PATCH 2/2] Bluetooth: Prevent uninitialized data access in L2CAP configuration Mat Martineau
2011-12-08  8:29   ` Marcel Holtmann
2011-12-08 21:32     ` Mat Martineau
2011-12-16 23:58 ` Mat Martineau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1112161557170.24351@mathewm-linux \
    --to=mathewm@codeaurora.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    --cc=pkrystad@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox