public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Mat Martineau <mathewm@codeaurora.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATC -v2 2/2] Bluetooth: Fix skb length calculation
Date: Wed, 9 May 2012 16:28:53 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1205091627350.2090@mathewm-linux> (raw)
In-Reply-To: <1336598836-28478-2-git-send-email-gustavo@padovan.org>


On Wed, 9 May 2012, Gustavo Padovan wrote:

> When we add a fragment to a skb, len, data_len and truesize fields needs
> to be updated.

truesize is not updated in this version of the patch.  Also, change 
"needs" to "need"

>
> Signed-off-by: Gustavo Padovan <gustavo@padovan.org>
> ---
> net/bluetooth/l2cap_core.c |    3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 66a1a55..f45f92d 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -1851,6 +1851,9 @@ static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan,
> 		sent += count;
> 		len  -= count;
>
> +		skb->len += (*frag)->len;
> +		skb->data_len += (*frag)->len;
> +
> 		frag = &(*frag)->next;
> 	}
>
> -- 
> 1.7.10.1

--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

  reply	other threads:[~2012-05-09 23:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 21:27 [PATC -v2 1/2] Bluetooth: Fix packet size informed to the controller Gustavo Padovan
2012-05-09 21:27 ` [PATC -v2 2/2] Bluetooth: Fix skb length calculation Gustavo Padovan
2012-05-09 23:28   ` Mat Martineau [this message]
2012-05-09 23:41     ` Gustavo Padovan
2012-05-09 22:30 ` [PATC -v2 1/2] Bluetooth: Fix packet size informed to the controller Gustavo Padovan
2012-05-09 23:27 ` Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1205091627350.2090@mathewm-linux \
    --to=mathewm@codeaurora.org \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox