From: Mat Martineau <mathewm@codeaurora.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv1 7/7] Bluetooth: Adjust L2CAP Max PDU size for AMP packets
Date: Fri, 5 Oct 2012 10:40:32 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1210051019460.5384@mathewm-linux> (raw)
In-Reply-To: <1349445419-16788-7-git-send-email-Andrei.Emeltchenko.news@gmail.com>
On Fri, 5 Oct 2012, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Maximum PDU size is defined by new BT Spec as 1492 octets.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> include/net/bluetooth/l2cap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 83fb9c7..caab98c 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -39,7 +39,7 @@
> #define L2CAP_DEFAULT_MAX_TX 3
> #define L2CAP_DEFAULT_RETRANS_TO 2000 /* 2 seconds */
> #define L2CAP_DEFAULT_MONITOR_TO 12000 /* 12 seconds */
> -#define L2CAP_DEFAULT_MAX_PDU_SIZE 1009 /* Sized for 3-DH5 packet */
> +#define L2CAP_DEFAULT_MAX_PDU_SIZE 1492 /* Sized for AMP packet */
> #define L2CAP_DEFAULT_ACK_TO 200
> #define L2CAP_DEFAULT_MAX_SDU_SIZE 0xFFFF
> #define L2CAP_DEFAULT_SDU_ITIME 0xFFFFFFFF
> --
> 1.7.9.5
I had missed this, thanks for fixing it. This makes AMP use the most
efficient PDU size for AMP controllers, while the size of the PDUs
sent on BR/EDR links will still be limited to
L2CAP_BR_EDR_MAX_PAYLOAD.
Reviewed-by: Mat Martineau <mathewm@codeaurora.org>
--
Mat Martineau
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2012-10-05 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 13:56 [PATCHv1 1/7] Bluetooth: L2CAP: Fix using default Flush Timeout for EFS Andrei Emeltchenko
2012-10-05 13:56 ` [PATCHv1 2/7] Bluetooth: AMP: Fix possible NULL dereference Andrei Emeltchenko
2012-10-05 13:56 ` [PATCHv1 3/7] Bluetooth: Fix dereference after NULL check Andrei Emeltchenko
2012-10-05 13:56 ` [PATCHv1 4/7] Bluetooth: AMP: Factor out amp_ctrl_add Andrei Emeltchenko
2012-10-05 13:56 ` [PATCHv1 5/7] Bluetooth: AMP: Factor out phylink_add Andrei Emeltchenko
2012-10-05 13:56 ` [PATCHv1 6/7] Bluetooth: AMP: Use block_mtu for AMP controller Andrei Emeltchenko
2012-10-05 13:56 ` [PATCHv1 7/7] Bluetooth: Adjust L2CAP Max PDU size for AMP packets Andrei Emeltchenko
2012-10-05 17:40 ` Mat Martineau [this message]
2012-10-07 22:25 ` Gustavo Padovan
2012-10-07 21:48 ` [PATCHv1 1/7] Bluetooth: L2CAP: Fix using default Flush Timeout for EFS Gustavo Padovan
2012-10-08 8:14 ` [PATCH] " Andrei Emeltchenko
2012-10-08 12:41 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1210051019460.5384@mathewm-linux \
--to=mathewm@codeaurora.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).