From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Li Jun <lijun01@kylinos.cn>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4] Bluetooth: pm: use SIMPLE_DEV_OPS for pm struct
Date: Thu, 20 Aug 2026 07:18:14 +0200 [thread overview]
Message-ID: <aoaMcmrLlLlsPonj@monoceros> (raw)
In-Reply-To: <20260820005058.1285971-1-lijun01@kylinos.cn>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
Hello,
On Thu, Aug 20, 2026 at 08:50:58AM +0800, Li Jun wrote:
> use SIMPLE_DEV_PM_OPS for btmrvl_sdio_pm_ops,and add the value of
> .freeze .thaw .poweroff .restore.if these address are null, may cause
> error in s4.
Please use spaces after punctuation marks.
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
Please apply what you learned during submission of similar patches.
There is no changelog describing what changed in v4. Also please use
pm_sleep_ptr() and practise some patience between revisions. Four
revisions within 24h is too much.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-20 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 0:50 [PATCH v4] Bluetooth: pm: use SIMPLE_DEV_OPS for pm struct Li Jun
2026-08-20 2:26 ` [v4] " bluez.test.bot
2026-08-20 5:18 ` Uwe Kleine-König [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-20 0:48 [PATCH v4] " Li Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoaMcmrLlLlsPonj@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=lijun01@kylinos.cn \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox