Re: [bug report] Bluetooth: btusb: Add support for Qualcomm multi-subsystem QCC2072

[Dan Carpenter <error27@gmail.com>]

On Sat, Sep 19, 2026 at 03:04:06PM +0800, Zijun Hu wrote:
> On 9/19/2026 1:07 PM, Dan Carpenter wrote:
> > Zero, sure.
> > 
> >    268  
> >    269          if (IS_ERR(skb)) {
> >    270                  if (!event)
> >    271                          bt_dev_err(hdev, "Opcode 0x%4.4x failed: %ld", opcode,
> >    272                                     PTR_ERR(skb));
> >    273                  return PTR_ERR(skb);
> >                         ^^^^^^^^^^^^^^^^^^^
> > Error pointer.  Fine.
> > 
> >    274          }
> >    275  
> >    276          status = skb->data[0];
> >    277  
> >    278          kfree_skb(skb);
> >    279  
> >    280          return status;
> >                 ^^^^^^^^^^^^^
> > But this seems like it could be a positive...
> > 
> 
> For HCI_OP_RESET, execution cannot reach this point when status != 0.
> 
> >    281  }

Actually even for the other opcodes it looks like doing:

	status = skb->data[0];
	return status;

is just a more complicated way to write "return 0;".  :/

regards,
dan carpenter