From: Michael Scott <michael@opensourcefoundries.com>
To: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: 6lowpan: Fix multi-link setup
Date: Thu, 7 Dec 2017 10:26:53 -0800 [thread overview]
Message-ID: <b17ba8fb-0ed2-a237-06c3-75ab0addbd86@opensourcefoundries.com> (raw)
Hi Luiz (and linux-bluetooth),
On Wed, 2017-09-20 at 12:52 +0300, Luiz Augusto von Dentz wrote:
>/From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>/
>//
>/If there are more than one node connected and there isn't any route/
>/information attempt to check if destination address matches any of/
>/the/
>/link-local peer addresses./
>//
>/Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>/
>/---/
>/net/bluetooth/6lowpan.c | 2 +-/
>/1 file changed, 1 insertion(+), 1 deletion(-)/
>//
>/diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c/
>/index 4e2576fc0c59..55370c330386 100644/
>/--- a/net/bluetooth/6lowpan.c/
>/+++ b/net/bluetooth/6lowpan.c/
>/@@ -190,7 +190,7 @@ static inline struct lowpan_peer/
>/*peer_lookup_dst(struct lowpan_btle_dev *dev,/
>/nexthop = &lowpan_cb(skb)->gw;/
>//
>/if (ipv6_addr_any(nexthop))/
>/- return NULL;/
>/+ nexthop = daddr;/
>/} else {/
>/nexthop = rt6_nexthop(rt, daddr);/
>//
Was there any plan to bring this into the longterm 4.14 tree? I saw
that Jukka ACKed the patch.
Using 4.14, connecting more than 1 node via 6lowpan is completely
broken. This fairly simple patch restores connectivity for multiple
6lowpan devices.
Question: Are there any hidden downsides to using this patch?
- Mike
next reply other threads:[~2017-12-07 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 18:26 Michael Scott [this message]
2017-12-07 18:55 ` [PATCH] Bluetooth: 6lowpan: Fix multi-link setup Luiz Augusto von Dentz
-- strict thread matches above, loose matches on Subject: below --
2017-09-20 9:52 Luiz Augusto von Dentz
2017-09-21 12:19 ` Jukka Rissanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b17ba8fb-0ed2-a237-06c3-75ab0addbd86@opensourcefoundries.com \
--to=michael@opensourcefoundries.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).