From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC5E80BFF for ; Sat, 12 Oct 2024 21:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728768168; cv=none; b=SB9Lo3qBlTwYJnrvzcpyI5Eh69qxRtD0oxOZPNeYlEb3hB0AUsICuQsD88ctak4r1bTxlMgolQ55Uf7TzYIp5kGJ5Tk0kTZ3OleB28ZG47N47+ZdGkakQHXhq+yn4oiDmtujFR+S4buPUDohqh2Lh14yD8dJ8ZMWQQGGAeyHD10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728768168; c=relaxed/simple; bh=3a3wOYjDqhVDslgmBGakj894kpqUL4UajFBZ4s3Z4Os=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pxtFhFj9Hp7cVvAYeJ7CaSDi0LzrWGLuYbTXLbnboXU1guaBZFekixwgD8YY9Nu5hJsZgzvgQ0vBnWCp001KnqYjDj7/aonw76TN71u9fV+upKzs/d0faQa9uQEbSwqXoFu3QpIuyaYzKbJRbNTHjK2/s6SHrReqtnptbNR4T04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m/xAcjkb; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m/xAcjkb" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5c962c3e97dso634950a12.0 for ; Sat, 12 Oct 2024 14:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728768165; x=1729372965; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=PhzSifK2ivcGwsy9b4W3SV0fTYamh8saianjd76i8c4=; b=m/xAcjkbHH7YRfPFhpTiDgxtR5kIhfn9Io5+yxtzgXMlg6ttpkbx9CYDXyOTDZxdhi 1jxcmUhy0Bb9ccrDAE2Fo+aRQ+Z7Zh7wzoNHP2jsHa0LaL8cCvn0qcE0QV1XnZcC2KVM nYFZYizsRmisRboVgYRU2Rp5xvzh/d968n2bML1D4raGMxNjENPokEbN5FShxqgbI5/e Vz0OsbwzIJwWceXqsEHzbSrCYE8/P6uQXWkB5Ft44qUWol2XhS8ZPmIXrAvXtFmAPP4E k7QKZiViG+vSiuGEuZH9Mw82UahouKVgdXoLHQ9oHcwYvQ2jhcD9KEGIyL2p8ALZOEIg cQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728768165; x=1729372965; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PhzSifK2ivcGwsy9b4W3SV0fTYamh8saianjd76i8c4=; b=NoO28qEP3FkmB+ilwC7HgNOUjSFNmfhfdxiArCQ0AO8rUnktUfqG1xbWsRl9ZloOlM 15gOGwDaRNJsq+L7CGkaQAZQEjOCd0Idy7uhKKkxIgK1qkb/nVKhkzhkbRhfqib9U+nR ESwV85LFDrhpFPLyw0jrS6H1KZMOISPAV1XnK9rQuS7lrt/mGGer4kEjVrbXOCUJYd4z Gptlr6sY/aPG2TeI4cAyvZQNMjfnVbHcDgeBfuDqYs2xfEzGz6XqdBzkRHnYJidtZ9i5 dMiDVFwlgwHzYJqIIyl6AL1c0VnF9IG5YvQNq63/iY1Bbj+w9hBDmLzPsdj3Ai/BiXqq KY6A== X-Forwarded-Encrypted: i=1; AJvYcCUKRjW4euW4S++CRxuaSYUHu6Fl+PQ6iHcB56THNXeEv99DylO8DoYtApoPJGE+3ty0g9GgKtyujwFGY2B79RM=@vger.kernel.org X-Gm-Message-State: AOJu0YyTrmP/KQzwH8B8xYFn98H5+YN5kUHjDqytMSYamuAultcR/1kH Sve0IEynQmYM1NHPPHxVpze55OX3PuvpPA1gGSa6wXK+VVUAd77K X-Google-Smtp-Source: AGHT+IGt4SRkxsZBdYNhOFahHPMavOT4Rb5UbQmzU4671TT/c0zqqrAgAze1Y7RPjA9ZqZMOeFsPLw== X-Received: by 2002:a05:6402:254f:b0:5c9:362f:142 with SMTP id 4fb4d7f45d1cf-5c948cca996mr4440578a12.21.1728768164848; Sat, 12 Oct 2024 14:22:44 -0700 (PDT) Received: from ?IPV6:2a02:3100:9cf5:9500:7452:8738:f913:7c31? (dynamic-2a02-3100-9cf5-9500-7452-8738-f913-7c31.310.pool.telefonica.de. [2a02:3100:9cf5:9500:7452:8738:f913:7c31]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5c93729adcdsm3189125a12.89.2024.10.12.14.22.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Oct 2024 14:22:42 -0700 (PDT) Message-ID: Date: Sat, 12 Oct 2024 23:22:41 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Connection issue since 81b3e33bb054 ("Bluetooth: btusb: Don't fail external suspend requests") To: Luiz Augusto von Dentz Cc: Luiz Augusto von Dentz , BlueZ development , Kiran K References: <595efd8b-e0fe-4a87-90b1-4b579f3cc876@gmail.com> <4492450a-aa01-49ae-9ff4-ef3641a6b6f2@gmail.com> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12.10.2024 00:19, Luiz Augusto von Dentz wrote: > Hi Heiner, > > On Fri, Oct 11, 2024 at 4:56 PM Heiner Kallweit wrote: >> >> On 11.10.2024 22:06, Luiz Augusto von Dentz wrote: >>> Hi Heiner, >>> >>> On Fri, Oct 11, 2024 at 3:44 PM Heiner Kallweit wrote: >>>> >>>> On 11.10.2024 21:26, Luiz Augusto von Dentz wrote: >>>>> Hi Heiner, >>>>> >>>>> On Fri, Oct 11, 2024 at 3:05 PM Luiz Augusto von Dentz >>>>> wrote: >>>>>> >>>>>> Hi Heiner, >>>>>> >>>>>> On Fri, Oct 11, 2024 at 2:52 PM Heiner Kallweit wrote: >>>>>>> >>>>>>> On 11.10.2024 18:36, Luiz Augusto von Dentz wrote: >>>>>>>> Hi Heiner, >>>>>>>> >>>>>>>> On Fri, Oct 11, 2024 at 6:49 AM Heiner Kallweit wrote: >>>>>>>>> >>>>>>>>> Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. >>>>>>>>> It just hangs trying. Manually connecting it via bluetoothctl works though. >>>>>>>>> With this patch reverted it auto-connects again. >>>>>>>>> If you need additional details, please let me know. >>>>>>>> >>>>>>>> I suspect something is trying to suspend the controller then, it >>>>>>>> shouldn't be USB auto-suspend since that should behave as it >>>>>>>> previously but if there is something externally (aka. userspace) >>>>>>>> trying to suspend then it will force it to suspend. >>>>>>>> >>>>>>> On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). >>>>>>> Runtime PM is enabled, so this may kick in. I'm not aware of any >>>>>>> userspace tool which may try to suspend the WiFi/BT adapter. >>>>>>> Disabling Runtime PM may be a workaround, but I don't think that's >>>>>>> the actual solution. >>>>>>> >>>>>> >>>>>> Well I assume it still using USB as transport, not PCIe, otherwise it >>>>>> wouldn't be using btusb. Regarding runtime PM, I assume it still means >>>>>> PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst: >>>>>> >>>>>> 'External suspend calls should never be allowed to fail in this way, >>>>>> only autosuspend calls. The driver can tell them apart by applying >>>>>> the :c:func:`PMSG_IS_AUTO` macro to the message argument to the >>>>>> ``suspend`` method; it will return True for internal PM events' >>>>>> >>>>>> -- >>>>>> Luiz Augusto von Dentz >>>>> >>>>> Perhaps there is a double call to the likes of hci_suspend_dev due to >>>>> system suspend and device suspend acting together, so maybe we need >>>>> something like the following: >>>>> >>>>> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c >>>>> index 779c4aeaef22..c257759ae2f4 100644 >>>>> --- a/net/bluetooth/hci_core.c >>>>> +++ b/net/bluetooth/hci_core.c >>>>> @@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev) >>>>> >>>>> /* Suspend should only act on when powered. */ >>>>> if (!hdev_is_powered(hdev) || >>>>> - hci_dev_test_flag(hdev, HCI_UNREGISTER)) >>>>> + hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended) >>>>> return 0; >>>>> >>>>> /* If powering down don't attempt to suspend */ >>>>> @@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev) >>>>> >>>>> /* Resume should only act on when powered. */ >>>>> if (!hdev_is_powered(hdev) || >>>>> - hci_dev_test_flag(hdev, HCI_UNREGISTER)) >>>>> + hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended) >>>>> return 0; >>>>> >>>>> /* If powering down don't attempt to resume */ >>>>> >>>>> >>>> No change in behavior with this change. >>> >>> Ok, I guess we can rule out system suspend then, does commenting out >>> the call to hci_suspend_dev makes it works again? If it does it means >>> the device is suspending and it appears the likes of >>> HCI_FLT_CONN_SETUP either doesn't work or is not being set to the >>> controller to allow incoming connections, since it is an Audio device >>> I think the problem is that we don't set HCI_CONN_FLAG_REMOTE_WAKEUP, >>> only input device do set it, so we may need to treat device suspend >>> and system suspend differently. >>> >> >> The following makes it work again. >> >> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c >> index 7860750ec..33fd65d49 100644 >> --- a/net/bluetooth/hci_core.c >> +++ b/net/bluetooth/hci_core.c >> @@ -2808,6 +2808,8 @@ int hci_suspend_dev(struct hci_dev *hdev) >> { >> int ret; >> >> + return 0; >> + >> bt_dev_dbg(hdev, ""); >> >> /* Suspend should only act on when powered. */ >> > > Can you try with the following changes: > > https://gist.github.com/Vudentz/52c0cf8b9472a03b8eb447951be13811 > In this patch all tabs have been replaced with spaces, therefore it didn't apply and I had to apply the changes manually. Unfortunately the changes don't fix the issue for me.