From: Ian W MORRISON <ianwmorrison@gmail.com>
To: marcel@holtmann.org, gustavo@padovan.org,
johan.hedberg@gmail.com,
"bluez mailin list (linux-bluetooth@vger.kernel.org)"
<linux-bluetooth@vger.kernel.org>
Cc: hdegoede@redhat.com, frederic.danis.oss@gmail.com
Subject: [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message
Date: Sat, 7 Oct 2017 17:16:08 +1100 [thread overview]
Message-ID: <b54325b3-280f-4fc0-b340-8e4b850af603@gmail.com> (raw)
As the overwriting of IRQ polarity to active low occurs during the driver probe using 'bt_dev_warn' to display the warning results in '(null)' being displayed for the device. This patch uses 'dev_warn' to correctly display the device in the warning instead.
Signed-off-by: ianwmorrison <ianwmorrison@gmail.com>
---
v2: Uses 'dev_warn' (Suggested-by: Marcel Holtmann <marcel@holtmann.org>)
Testing shows the following improvements using an extract from dmesg of the affected message:
Without patch:
[ 5.512175] Bluetooth: (null): MINIX Z83-4: Overwriting IRQ polarity to active low
v1 (superseded) patch:
[ 5.592238] Bluetooth: MINIX Z83-4: Overwriting IRQ polarity to active low
v2 patch (with a kernel excluding serdev ACPI support patches):
[ 6.112265] hci_bcm BCM2EA4:00: MINIX Z83-4: Overwriting IRQ polarity to active low
v2 patch (with a kernel including serdev ACPI support patches):
[ 6.367829] hci_uart_bcm serial1-0: MINIX Z83-4: Overwriting IRQ polarity to active low
---
drivers/bluetooth/hci_bcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 77326eeb6146..16c2eaaaf72b 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -839,7 +839,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
if (dmi_id) {
- bt_dev_warn(dev, "%s: Overwriting IRQ polarity to active low",
+ dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
dmi_id->ident);
dev->irq_active_low = true;
}
--
2.11.0
next reply other threads:[~2017-10-07 6:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 6:16 Ian W MORRISON [this message]
2017-10-09 13:52 ` [PATCH v2] Bluetooth: hci_bcm: Correct context of IRQ polarity message Hans de Goede
2017-10-09 18:04 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b54325b3-280f-4fc0-b340-8e4b850af603@gmail.com \
--to=ianwmorrison@gmail.com \
--cc=frederic.danis.oss@gmail.com \
--cc=gustavo@padovan.org \
--cc=hdegoede@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).