From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2202B1E5B63; Wed, 1 Oct 2025 06:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759299540; cv=none; b=rdDnB7ZFzUG+ZlnHvToEi6jJW47OVmjfLddRYRFEtFXofkxI539Iu5BIQMIdjFjk6iYlsKPxhVwURF/XQYx7L3wAM06dD+N9J8KDXUjAncc3hx4BOuu2w1X+Jt7uxu52F3q9YGGShE4f5lPlr3XUYAxb4hahz5WYfDfunYUZR9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759299540; c=relaxed/simple; bh=tE+0yJepW2V2w1DRVBg8Ox3t6Pll9UqKyDXb0OgrRTc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IklxDGfB0OHB3nAK+Vy/bWhCVTurJClyF099mZqWALTV6551YHYJlctdfF00AWYcuBZqrMyLJrm8YTBUtz6J6jTh+m8u0+pJYv1WOTp44yy0D1VxpS7ojYxkqtj8Zo/zsS10aCI00lhx8fKrVgPvS1z6ID7WehQGhl8hbilqrvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [192.168.2.212] (p57bd9782.dip0.t-ipconnect.de [87.189.151.130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id D634E6028F357; Wed, 01 Oct 2025 08:18:40 +0200 (CEST) Message-ID: Date: Wed, 1 Oct 2025 08:18:39 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] Bluetooth: btusb: Add new VID/PID 0489/e170 for MT7922 To: Chris Lu Cc: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz , Sean Wang , Will Lee , SS Wu , Steve Lee , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20251001060437.2298529-1-chris.lu@mediatek.com> <20251001060437.2298529-3-chris.lu@mediatek.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20251001060437.2298529-3-chris.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Dear Chris, Thank you for your patch. Same comments as in patch 1/1. Am 01.10.25 um 08:04 schrieb Chris Lu: > Add VID 0489 & PID e170 for MediaTek MT7922 USB Bluetooth chip. > > The information in /sys/kernel/debug/usb/devices about the Bluetooth > device is listed as the below. > > T: Bus=06 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0489 ProdID=e170 Rev= 1.00 > S: Manufacturer=MediaTek Inc. > S: Product=Wireless_Device > S: SerialNumber=000000000 > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA > A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01 > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms > I:* If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us > I: If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) > E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us > E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us > > Signed-off-by: Chris Lu > --- > drivers/bluetooth/btusb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index a2cde2284163..6834592f3c39 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -687,6 +687,8 @@ static const struct usb_device_id quirks_table[] = { > BTUSB_WIDEBAND_SPEECH }, > { USB_DEVICE(0x0489, 0xe153), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH }, > + { USB_DEVICE(0x0489, 0xe170), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH }, > { USB_DEVICE(0x04ca, 0x3804), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH }, > { USB_DEVICE(0x04ca, 0x38e4), .driver_info = BTUSB_MEDIATEK | Reviewed-by: Paul Menzel Kind regards, Paul