From: Johannes Berg <johannes@sipsolutions.net>
To: Manish Mandlik <mmandlik@google.com>,
Arend van Spriel <aspriel@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
marcel@holtmann.org, luiz.dentz@gmail.com
Cc: Dan Williams <dan.j.williams@intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-bluetooth@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
chromeos-bluetooth-upstreaming@chromium.org,
Won Chung <wonchung@google.com>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] sysfs: Add attribute info for /sys/devices/.../coredump_disabled
Date: Wed, 10 Aug 2022 18:03:37 +0200 [thread overview]
Message-ID: <bfc5f964d8dadd6378f2da5b3b6ef4bc9fb847c2.camel@sipsolutions.net> (raw)
In-Reply-To: <20220810085753.v5.1.I5622b2a92dca4d2703a0f747e24f3ef19303e6df@changeid>
On Wed, 2022-08-10 at 09:00 -0700, Manish Mandlik wrote:
> This patch adds the specification for /sys/devices/.../coredump_disabled
> attribute which allows the userspace to enable/disable devcoredump for a
> particular device and drivers can use it to enable/disable functionality
> accordingly. It is available when the CONFIG_DEV_COREDUMP is enabled and
> driver has implemented the .coredump() callback.
>
It would be nice to say _why_? What problem does this solve? You could
just create the dump and discard it, instead, for example?
johannes
next prev parent reply other threads:[~2022-08-10 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 16:00 [PATCH v5 1/5] sysfs: Add attribute info for /sys/devices/.../coredump_disabled Manish Mandlik
2022-08-10 16:00 ` [PATCH v5 2/5] devcoredump: Add per device sysfs entry to enable/disable coredump Manish Mandlik
2022-08-10 16:00 ` [PATCH v5 3/5] Bluetooth: Add support for hci devcoredump Manish Mandlik
2022-08-10 16:19 ` Greg Kroah-Hartman
2022-08-12 18:59 ` kernel test robot
2022-08-12 19:19 ` kernel test robot
2022-08-10 16:00 ` [PATCH v5 4/5] Bluetooth: btusb: Add btusb devcoredump support Manish Mandlik
2022-08-10 16:20 ` Greg Kroah-Hartman
2022-08-10 16:00 ` [PATCH v5 5/5] Bluetooth: btintel: Add Intel " Manish Mandlik
2022-08-10 16:21 ` Greg Kroah-Hartman
2022-08-10 16:03 ` Johannes Berg [this message]
2022-08-10 16:21 ` [PATCH v5 1/5] sysfs: Add attribute info for /sys/devices/.../coredump_disabled Greg Kroah-Hartman
[not found] ` <CAGPPCLAV=mnMcteCnqFT5zdbWdZuFQRv6-oxC3qAnLh8_8H61Q@mail.gmail.com>
2022-08-12 6:09 ` Greg Kroah-Hartman
2022-08-13 9:39 ` Arend van Spriel
2022-08-10 16:22 ` Greg Kroah-Hartman
2022-08-10 17:25 ` [v5,1/5] " bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfc5f964d8dadd6378f2da5b3b6ef4bc9fb847c2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=abhishekpandit@chromium.org \
--cc=aspriel@gmail.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mmandlik@google.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=wonchung@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox