Linux bluetooth development
 help / color / mirror / Atom feed
From: Pauli Virtanen <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/action-ci] c01507: Use AddressSanitizer instead of Valgrind for testers
Date: Wed, 09 Sep 2026 11:54:40 -0700	[thread overview]
Message-ID: <bluez/action-ci/push/refs/heads/main/1e08fd-9693b1@github.com> (raw)

  Branch: refs/heads/main
  Home:   https://github.com/bluez/action-ci
  Commit: c01507fbe25ba02f0274de077dae262d9d0c96da
      https://github.com/bluez/action-ci/commit/c01507fbe25ba02f0274de077dae262d9d0c96da
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-09 (Wed, 09 Sep 2026)

  Changed paths:
    M ci/testrunner.py
    M ci/testrunnersetup.py

  Log Message:
  -----------
  Use AddressSanitizer instead of Valgrind for testers

On blueztestbot/bluez-build:latest (d5484a10bde6) from 2022-12-20,
testers ran with valgrind work, but they fail with timeouts when using
image rebuilt from https://github.com/BluezTestBot/docker-bluez-build
(89186b243e08) that should correspond to the source of the original
image.

As we cannot stay with unreproducible CI image, this should be fixed.

As the cause of the issue is unclear, switch to using ASan instead of
valgrind.

Example (with intentional crasher added in iso-tester)
------------------------------------------------------
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Sanitizer errors:
==33==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7bab5fd7f2e2 at pc 0x55d17f8a90d6 bp 0x7fff0e52b3c0 sp 0x7fff0e52b3b0
WRITE of size 1 at 0x7bab5fd7f2e2 thread T0
    #0 0x55d17f8a90d5 in test_connect_close tools/iso-tester.c:3714
    #1 0x55d17f9737c9 in run_callback src/shared/tester.c:512
    #2 0x7fab627fbb9a  (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x60b9a) (BuildId: 2426ee6f828a10bf4da963a4c474752c33742359)
    #3 0x7fab627fd1d6  (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x621d6) (BuildId: 2426ee6f828a10bf4da963a4c474752c33742359)
    #4 0x7fab627fd576 in g_main_loop_run (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x62576) (BuildId: 2426ee6f828a10bf4da963a4c474752c33742359)
    #5 0x55d17f977c08 in mainloop_run src/shared/mainloop-glib.c:65
    #6 0x55d17f97853a in mainloop_run_with_signal src/shared/mainloop-notify.c:196
    #7 0x55d17f9766fb in tester_run src/shared/tester.c:1085
    #8 0x55d17f8a3951 in main tools/iso-tester.c:4402
    #9 0x7fab61f87600 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:59
    #10 0x7fab61f87717 in __libc_start_main_impl ../csu/libc-start.c:360
    #11 0x55d17f8a8ef4 in _start (/work/base/bluez/tools/iso-tester+0x16bef4) (BuildId: c55e00a4de821cd607408898c962c16c12e2322c)

Address 0x7bab5fd7f2e2 is located in stack of thread T0 at offset 34 in frame
    #0 0x55d17f8a8fcf in test_connect_close tools/iso-tester.c:3706

  This frame has 1 object(s):
    [32, 34) 'buf' (line 3710) <== Memory access at offset 34 overflows this variable
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
      (longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow tools/iso-tester.c:3714 in test_connect_close
No test result found


  Commit: 9693b14748368889034e742eae601c1a6fa7c8b7
      https://github.com/bluez/action-ci/commit/9693b14748368889034e742eae601c1a6fa7c8b7
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-09 (Wed, 09 Sep 2026)

  Changed paths:
    M Dockerfile

  Log Message:
  -----------
  Use CI image in Github container registry

Use image from Github container registry, built via Github actions so
that it is easier to manage, without needing dockerhub or any other
additional secrets.

This image includes LLVM 23 prerelease from kernel.org.

NOTE: The image is currently built from my personal account,
https://github.com/pv/bluez-ci-image/pkgs/container/bluez-ci-image but
probably the repository should be copied in the organization and the
image name changed accordingly.


Compare: https://github.com/bluez/action-ci/compare/1e08fd655d42...9693b1474836

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/action-ci/settings/notifications

                 reply	other threads:[~2026-09-09 18:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/action-ci/push/refs/heads/main/1e08fd-9693b1@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox