From: hadess <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] c769d9: mpris-proxy: Fix possible crash
Date: Tue, 05 May 2026 04:41:35 -0700 [thread overview]
Message-ID: <bluez/bluez/push/refs/heads/1089833/000000-5e18ca@github.com> (raw)
Branch: refs/heads/1089833
Home: https://github.com/bluez/bluez
Commit: c769d9067d1ae278388d81103e7ede3d921c9fed
https://github.com/bluez/bluez/commit/c769d9067d1ae278388d81103e7ede3d921c9fed
Author: Bastien Nocera <hadess@hadess.net>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
M tools/mpris-proxy.c
Log Message:
-----------
mpris-proxy: Fix possible crash
find_player_by_obex() doesn't check whether session->obex is a valid
pointer before dereferecing it, but all code paths that assign it use
create_obex_session() to assign it, a function that can fail.
Check whether session->obex is null before dereferencing it.
#0 find_player_by_obex at tools/mpris-proxy.c:2819
#1 obex_property_changed at tools/mpris-proxy.c:2929
#2 add_property at gdbus/client.c:373
#3 update_properties at gdbus/client.c:399
#5 properties_changed at gdbus/client.c:537
#6 signal_filter at gdbus/watch.c:416
#7 message_filter at gdbus/watch.c:566
#10 message_dispatch at gdbus/mainloop.c:59
#13 g_main_context_dispatch_unlocked at ../glib/gmain.c:4451
#14 g_main_context_iterate_unlocked at ../glib/gmain.c:4516
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2466640
Commit: 5e18ca222abc7a7744fe9f2d47cf2f6cb8efb191
https://github.com/bluez/bluez/commit/5e18ca222abc7a7744fe9f2d47cf2f6cb8efb191
Author: Bastien Nocera <hadess@hadess.net>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
M tools/mpris-proxy.c
Log Message:
-----------
mpris-proxy: Avoid session->obex dereference
Protect against trying to access session->obex variable that might be
null after failure to create the session object.
Compare: https://github.com/bluez/bluez/compare/c769d9067d1a%5E...5e18ca222abc
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
reply other threads:[~2026-05-05 11:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bluez/bluez/push/refs/heads/1089833/000000-5e18ca@github.com \
--to=noreply@github.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox