Linux bluetooth development
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 331e9d: tools/tester: Fix crash when hciemu_new fails
Date: Wed, 06 May 2026 13:23:27 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/1090665/000000-63ea27@github.com> (raw)

  Branch: refs/heads/1090665
  Home:   https://github.com/bluez/bluez
  Commit: 331e9d2b22eb2abd7d4f46268ac86c2276091283
      https://github.com/bluez/bluez/commit/331e9d2b22eb2abd7d4f46268ac86c2276091283
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M tools/6lowpan-tester.c
    M tools/bnep-tester.c
    M tools/ioctl-tester.c
    M tools/iso-tester.c
    M tools/l2cap-tester.c
    M tools/mesh-tester.c
    M tools/mgmt-tester.c
    M tools/rfcomm-tester.c
    M tools/sco-tester.c
    M tools/smp-tester.c
    M tools/userchan-tester.c

  Log Message:
  -----------
  tools/tester: Fix crash when hciemu_new fails

When hciemu_new returns NULL, the mgmt object was not being unreferenced
before returning from the pre-setup failure path. This could lead to a
NULL dereference in read_info_callback when it later calls
hciemu_get_address on the NULL hciemu pointer.

Add mgmt_unref and return to the error path across all testers.


  Commit: a00fdf8c694eb05d2099f3d8a110296eafc77453
      https://github.com/bluez/bluez/commit/a00fdf8c694eb05d2099f3d8a110296eafc77453
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M emulator/hciemu.c
    M emulator/hciemu.h

  Log Message:
  -----------
  emulator/hciemu: Add hciemu_new_debug/hciemu_new_num_debug

Add new constructors that accept debug callback and user_data parameters,
setting them up immediately after allocation so errors during early
initialization (create_vhci, hciemu_client_new) are captured by the debug
output.


  Commit: 63ea27eca0e63307069d4966248fe7a8610560a2
      https://github.com/bluez/bluez/commit/63ea27eca0e63307069d4966248fe7a8610560a2
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M tools/6lowpan-tester.c
    M tools/bnep-tester.c
    M tools/ioctl-tester.c
    M tools/iso-tester.c
    M tools/l2cap-tester.c
    M tools/mesh-tester.c
    M tools/mgmt-tester.c
    M tools/rfcomm-tester.c
    M tools/sco-tester.c
    M tools/smp-tester.c
    M tools/userchan-tester.c

  Log Message:
  -----------
  tools/tester: Retry with debug on hciemu_new failure

When hciemu_new fails, retry using hciemu_new_debug to capture early
initialization errors before reporting the failure. This helps diagnose
issues like vhci or client creation failures in CI.


Compare: https://github.com/bluez/bluez/compare/331e9d2b22eb%5E...63ea27eca0e6

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

                 reply	other threads:[~2026-05-06 20:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/1090665/000000-63ea27@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox