public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [bluez/bluez] 0590d6: shared/util: Add strtoutf8 function
@ 2025-07-08  7:20 fdanis-oss
  0 siblings, 0 replies; only message in thread
From: fdanis-oss @ 2025-07-08  7:20 UTC (permalink / raw)
  To: linux-bluetooth

  Branch: refs/heads/979916
  Home:   https://github.com/bluez/bluez
  Commit: 0590d61013a5481bcf93876359e8e7df522ea0e9
      https://github.com/bluez/bluez/commit/0590d61013a5481bcf93876359e8e7df522ea0e9
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M src/shared/util.c
    M src/shared/util.h

  Log Message:
  -----------
  shared/util: Add strtoutf8 function

This adds the strtoutf8 function that truncate a string before the
first non UTF-8 character.
This truncation is done in place.


  Commit: 8074c549df269742300841982c005c070ccc42ba
      https://github.com/bluez/bluez/commit/8074c549df269742300841982c005c070ccc42ba
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M profiles/audio/avrcp.c

  Log Message:
  -----------
  audio/avrcp: Fix crash with invalid UTF-8 item name

As stated in AVRCP 1.6.2 chapter 6.10.2.3 Media element item, for the
Displayable Name Length property, the target device may truncate the
item name:

  Length of Displayable Name in octets. The name shall be limited such
  that a response to a GetFolderItems containing one media player item
  fits within the maximum size of PDU which can be received by the CT.

This truncatation may occur in the middle of a multi-byte character,
at least with Samsung Music app, which triggers a DBus assertion and
crashes bluetoothd:

  profiles/audio/player.c:media_folder_create_item() Din Dhal Jaye
      Haye with lyrics | "दिन ढल जाए
      हाय" गाने के बो� type audio uid 1
  profiles/audio/player.c:media_folder_create_item()
      /org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1
  profiles/audio/player.c:media_player_set_metadata() Title: Din Dhal
      Jaye Haye with lyrics | "दिन ढल जाए हाय"
      गाने के बोल | Guide | Dev Anand, Waheeda Rehman
  …
  arguments to dbus_message_iter_append_basic() were incorrect,
      assertion "_dbus_check_is_valid_utf8 (*string_p)" failed in
      file dbus-message.c line 2775.
  This is normally a bug in some application using the D-Bus library.


  Commit: 262d974e1774ca31870186e48800c3b76134828f
      https://github.com/bluez/bluez/commit/262d974e1774ca31870186e48800c3b76134828f
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M profiles/audio/mcp.c

  Log Message:
  -----------
  audio/mcp: Use strtoutf8 for player name and track title

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


  Commit: 0233c9bb284bdc2e8dd93e21df0b612a1baa894a
      https://github.com/bluez/bluez/commit/0233c9bb284bdc2e8dd93e21df0b612a1baa894a
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M profiles/gap/gas.c

  Log Message:
  -----------
  audio/gap: Use strtoutf8 for GAP device name

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


  Commit: 1c2af2b9c6da05f52d36663ec0aa314a96bb24e1
      https://github.com/bluez/bluez/commit/1c2af2b9c6da05f52d36663ec0aa314a96bb24e1
  Author: Frédéric Danis <frederic.danis@collabora.com>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M src/eir.c

  Log Message:
  -----------
  eir: Use strtoutf8 for device names

Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces.


Compare: https://github.com/bluez/bluez/compare/0590d61013a5%5E...1c2af2b9c6da

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-07-08  7:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-08  7:20 [bluez/bluez] 0590d6: shared/util: Add strtoutf8 function fdanis-oss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox