From: Myrrh Periwinkle <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 5db6d2: audio: Don't initialize media transport volume fro...
Date: Tue, 12 Aug 2025 11:23:21 -0700 [thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/0491cd-9cdbad@github.com> (raw)
Branch: refs/heads/master
Home: https://github.com/bluez/bluez
Commit: 5db6d2fef66fb87217b7795b3d24372e219a9692
https://github.com/bluez/bluez/commit/5db6d2fef66fb87217b7795b3d24372e219a9692
Author: Myrrh Periwinkle <myrrhperiwinkle@qtmlabs.xyz>
Date: 2025-08-12 (Tue, 12 Aug 2025)
Changed paths:
M profiles/audio/avrcp.c
M profiles/audio/media.c
M profiles/audio/media.h
Log Message:
-----------
audio: Don't initialize media transport volume from media player
Media player objects may be shared between devices. As a result,
a device without support for hardware volume that is connected after one
that does may end up being erroneously considered hardware
volume-capable.
fa7828bdd ("transport: Fix not being able to initialize volume properly")
introduced btd_device_{get,set}_volume that is used as an alternative in
case no media player objects are present. Therefore, we can remove
media_player_get_device_volume and instead use btd_device_get_volume to
determine the initial volume.
Commit: 9cdbad590b7476b83e2ef240a486fd5159251be8
https://github.com/bluez/bluez/commit/9cdbad590b7476b83e2ef240a486fd5159251be8
Author: Myrrh Periwinkle <myrrhperiwinkle@qtmlabs.xyz>
Date: 2025-08-12 (Tue, 12 Aug 2025)
Changed paths:
M profiles/audio/avrcp.c
M profiles/audio/avrcp.h
M profiles/audio/media.c
Log Message:
-----------
audio: Remove media_player.volume
With the previous commit, the media_player.volume field is now
completely unused. As this was never the right place to store the
initial volume to begin with, remove this field entirely as well as its
associated supporting methods to prevent confusion.
Compare: https://github.com/bluez/bluez/compare/0491cdf31754...9cdbad590b74
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
reply other threads:[~2025-08-12 18:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bluez/bluez/push/refs/heads/master/0491cd-9cdbad@github.com \
--to=noreply@github.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).