public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: BluezTestBot <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 1de417: audio/transport: Propagate errors from avrcp_set_v...
Date: Tue, 21 Mar 2023 09:19:17 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/4a3f46-338ba4@github.com> (raw)

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: 1de41786c1a22fe0d4f55805f3006ce66e5c65a6
      https://github.com/bluez/bluez/commit/1de41786c1a22fe0d4f55805f3006ce66e5c65a6
  Author: Marijn Suijten <marijn.suijten@somainline.org>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M profiles/audio/transport.c

  Log Message:
  -----------
  audio/transport: Propagate errors from avrcp_set_volume to DBus

Any error while setting absolute volume on the peer, or notifying the
peer of changes was previously going completely unnoticed.  Propagate it
to the logs and back to the DBus "Volume" property setter so that they
aren't misled into thinking that the AVRCP command succeeded.

Note that an error is mostly harmless when the setter of the property is
an audio sink and the peer the audio source: in this case we're only
_notifying_ the peer of the change when it has already been applied on
the sink.

Also improve the other two error messages to more closely describe what
was "invalid" about the argument.


  Commit: 338ba4352b6cadafe61808c21302c0abe2168e02
      https://github.com/bluez/bluez/commit/338ba4352b6cadafe61808c21302c0abe2168e02
  Author: Aaron_shen <aarongt.shen@gmail.com>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M obexd/src/manager.c

  Log Message:
  -----------
  obexd: reject to accept file when replying reject message

It will accept file when obex agent replied any message
event though the message is org.bluez.obex.Error.Rejected.
The patch helps to reject a Bluetooth object push request if
user replied "org.bluez.obex.Error.Rejected" message according
to the doc/obex-agent-api.txt.


Compare: https://github.com/bluez/bluez/compare/4a3f465a55c9...338ba4352b6c

                 reply	other threads:[~2023-03-21 16:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/master/4a3f46-338ba4@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox