From: Pauli Virtanen <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 769335: transport: clean up volume set/get for A2DP and VCP
Date: Thu, 08 Jan 2026 11:54:27 -0800 [thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/561d4e-1287ac@github.com> (raw)
Branch: refs/heads/master
Home: https://github.com/bluez/bluez
Commit: 76933585dc4815fa7815df3903a21d9fa6431c34
https://github.com/bluez/bluez/commit/76933585dc4815fa7815df3903a21d9fa6431c34
Author: Pauli Virtanen <pav@iki.fi>
Date: 2026-01-07 (Wed, 07 Jan 2026)
Changed paths:
M profiles/audio/avrcp.c
M profiles/audio/media.c
M profiles/audio/media.h
M profiles/audio/transport.c
M profiles/audio/transport.h
M profiles/audio/vcp.c
M profiles/audio/vcp.h
Log Message:
-----------
transport: clean up volume set/get for A2DP and VCP
Cleanup uuid comparisons in device transport volume set/get. These are
unnecessary because the transport->ops already do the equivalent check.
Use separate functions for set/get AVRCP volume, to avoid mixing up
AVRCP and VCP volumes.
For VCP send volume update notifications on all transports, since same
volume is listed on all.
To avoid interspersing #ifdefs for A2DP/VCP in this code, define dummy
functions in headers that behave accordingly.
Fix the bt_audio_vcp_get/set_volume to properly indicate when VCP is not
present.
Commit: 1287ac9068b748cdb3c48260d0a4b93466f24784
https://github.com/bluez/bluez/commit/1287ac9068b748cdb3c48260d0a4b93466f24784
Author: Pauli Virtanen <pav@iki.fi>
Date: 2026-01-07 (Wed, 07 Jan 2026)
Changed paths:
M profiles/audio/transport.c
Log Message:
-----------
transport: distinguish BAP mic and playback volumes
BAP Unicast has two kinds of relevant volumes: playback and microphone.
Client Sink and Server Source generally correspond to microphone volume.
Broadcast Source and Sink do not have microphone volume. Microphone
volumes shall use MICP, not VCP, but currently we confuse them.
Fix by distinguishing the VCP / MICP cases. The shared/micp
implementation is incomplete, so leave those volumes unimplemented also
in transport.
This fixes setting volume on microphone transport changing the playback
volume.
Compare: https://github.com/bluez/bluez/compare/561d4e815f28...1287ac9068b7
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
reply other threads:[~2026-01-08 19:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bluez/bluez/push/refs/heads/master/561d4e-1287ac@github.com \
--to=noreply@github.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox