public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [bluez/bluez] 769335: transport: clean up volume set/get for A2DP and VCP
@ 2026-01-08 19:54 Pauli Virtanen
  0 siblings, 0 replies; only message in thread
From: Pauli Virtanen @ 2026-01-08 19:54 UTC (permalink / raw)
  To: linux-bluetooth

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: 76933585dc4815fa7815df3903a21d9fa6431c34
      https://github.com/bluez/bluez/commit/76933585dc4815fa7815df3903a21d9fa6431c34
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-01-07 (Wed, 07 Jan 2026)

  Changed paths:
    M profiles/audio/avrcp.c
    M profiles/audio/media.c
    M profiles/audio/media.h
    M profiles/audio/transport.c
    M profiles/audio/transport.h
    M profiles/audio/vcp.c
    M profiles/audio/vcp.h

  Log Message:
  -----------
  transport: clean up volume set/get for A2DP and VCP

Cleanup uuid comparisons in device transport volume set/get. These are
unnecessary because the transport->ops already do the equivalent check.

Use separate functions for set/get AVRCP volume, to avoid mixing up
AVRCP and VCP volumes.

For VCP send volume update notifications on all transports, since same
volume is listed on all.

To avoid interspersing #ifdefs for A2DP/VCP in this code, define dummy
functions in headers that behave accordingly.

Fix the bt_audio_vcp_get/set_volume to properly indicate when VCP is not
present.


  Commit: 1287ac9068b748cdb3c48260d0a4b93466f24784
      https://github.com/bluez/bluez/commit/1287ac9068b748cdb3c48260d0a4b93466f24784
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-01-07 (Wed, 07 Jan 2026)

  Changed paths:
    M profiles/audio/transport.c

  Log Message:
  -----------
  transport: distinguish BAP mic and playback volumes

BAP Unicast has two kinds of relevant volumes: playback and microphone.
Client Sink and Server Source generally correspond to microphone volume.
Broadcast Source and Sink do not have microphone volume.  Microphone
volumes shall use MICP, not VCP, but currently we confuse them.

Fix by distinguishing the VCP / MICP cases. The shared/micp
implementation is incomplete, so leave those volumes unimplemented also
in transport.

This fixes setting volume on microphone transport changing the playback
volume.


Compare: https://github.com/bluez/bluez/compare/561d4e815f28...1287ac9068b7

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-01-08 19:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 19:54 [bluez/bluez] 769335: transport: clean up volume set/get for A2DP and VCP Pauli Virtanen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox