public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: mdzik-sue <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 322cc2: transport: allow setting Metadata property on broa...
Date: Mon, 20 Apr 2026 13:24:54 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/73c694-bc0a83@github.com> (raw)

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: 322cc2eb736c7f2a95ea13cda14fb0fbf57cdb64
      https://github.com/bluez/bluez/commit/322cc2eb736c7f2a95ea13cda14fb0fbf57cdb64
  Author: Michal Dzik <michal.dzik@streamunlimited.com>
  Date:   2026-04-20 (Mon, 20 Apr 2026)

  Changed paths:
    M profiles/audio/transport.c

  Log Message:
  -----------
  transport: allow setting Metadata property on broadcast

Also fixes a problem where 64-bit iov_len was incorrectly initialized with
32-bit value in dbus_message_iter_get_fixed_array().


  Commit: 4771fd2fed346564ed322573d8c2a691b1fe8565
      https://github.com/bluez/bluez/commit/4771fd2fed346564ed322573d8c2a691b1fe8565
  Author: Michal Dzik <michal.dzik@streamunlimited.com>
  Date:   2026-04-20 (Mon, 20 Apr 2026)

  Changed paths:
    M src/shared/bap.c

  Log Message:
  -----------
  shared/bap: run callback after setting the broadcast metadata

Without this callback, dbus property setting will stall.


  Commit: 9d8d8cbd47498c412021dfc76ce715678e9aa762
      https://github.com/bluez/bluez/commit/9d8d8cbd47498c412021dfc76ce715678e9aa762
  Author: Michal Dzik <michal.dzik@streamunlimited.com>
  Date:   2026-04-20 (Mon, 20 Apr 2026)

  Changed paths:
    M profiles/audio/bap.c

  Log Message:
  -----------
  audio/bap: fill BIG and BIS for receiver

This is for some reason a missing feature.
We receive QoS structure from the kernel via BT_ISO_QOS, but BIG and BIS
are not set there. In fact it is even impossible to pass them that way,
as it is only one structure per remote device. That's why we have to parse
BASE data to extract BIS and set it to stream->qos. BIG is not present
explicitly in BASE, but we can use subgroup index with success.

As a result of this commit, MediaTransport1 object has now a valid BIG
and BIS set in QoS property.


  Commit: bc0a839fa3839823a5c1e51a687d9adbb6156b8b
      https://github.com/bluez/bluez/commit/bc0a839fa3839823a5c1e51a687d9adbb6156b8b
  Author: Michal Dzik <michal.dzik@streamunlimited.com>
  Date:   2026-04-20 (Mon, 20 Apr 2026)

  Changed paths:
    M profiles/audio/transport.c

  Log Message:
  -----------
  audio: update QoS dbus property after it is set

Dbus set and get on QoS property use different data:
- get uses bap->qos
- set uses bap->stream->qos
This works, because bap->qos is a copy of bap->stream->qos. The only
issue is when we set this property and then try to get it. We see old, not
updated copy. Simply calling bap_update_bcast_qos() fixes the problem.


Compare: https://github.com/bluez/bluez/compare/73c6943f0636...bc0a839fa383

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

                 reply	other threads:[~2026-04-20 20:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/master/73c694-bc0a83@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox